Added SUCCESS_WITH_INFO support for PL/SQL functions used in executeMany()

Author: sharadraju

doc/src/api_manual/connection.rst

@@ -1399,6 +1399,15 @@ Connection Methods
             It is only present if a DML statement was executed.
 
             Due to Node.js type limitations, the largest value shown will be 232 - 1, even if more rows were affected. Larger values will wrap.
+        * - ``warning``
+          - Object
+          - .. _execmanywarning:
+
+            This property provides an :ref:`error <errorobj>` object that gives information about any database warnings (such as PL/SQL compilation warnings) that were generated during the last call to :meth:`connection.executeMany()`.
+
+            See :ref:`plsqlcompwarnings` for more information.
+
+            .. versionadded:: 6.4
 
 .. method:: connection.getDbObjectClass()
 

doc/src/release_notes.rst

@@ -13,6 +13,10 @@ node-oracledb `v6.4.0 <https://github.com/oracle/node-oracledb/compare/v6.3.0...
 Common Changes
 ++++++++++++++
 
+#)  Added the :ref:`warning <execmanywarning>` property to the
+    :ref:`result <resultobjproperties>` object of
+    :meth:`connection.executeMany()`.
+
 #)  Attribute and element values of :ref:`DbObject Class
     <dbobjectclass>` objects that contain strings or bytes now have their
     maximum size constraints checked. Errors ``NJS-142`` and ``NJS-143`` are

doc/src/user_guide/plsql_execution.rst

@@ -453,7 +453,7 @@ messages are sometimes known in Oracle as "success with info" messages). Your
 application can manually check for these messages using the
 :ref:`warning <execwarning>` property of the
 :ref:`result object <resultobject>` in :meth:`connection.execute()` or
-:meth:`connection.executemany()`. A subsequent query from a table like
+:meth:`connection.executeMany()`. A subsequent query from a table like
 ``USER_ERRORS`` will show more details. For example:
 
 .. code-block:: javascript

lib/connection.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2016, 2023, Oracle and/or its affiliates.
+// Copyright (c) 2016, 2024, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //
@@ -949,6 +949,11 @@ class Connection extends EventEmitter {
     const result = await this._impl.execute(sql, numIters, binds, options,
       true);
 
+    // convert ORA warnings to NJS
+    if (result.warning) {
+      result.warning = errors.transformErr(result.warning);
+    }
+
     // process output binds
     if (result.outBinds !== undefined) {
       for (let i = 0; i < result.outBinds.length; i++) {

src/njsConnection.c

@@ -1,4 +1,4 @@
-// Copyright (c) 2015, 2023, Oracle and/or its affiliates.
+// Copyright (c) 2015, 2024, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //
@@ -834,6 +834,7 @@ static bool njsConnection_executeManyAsync(njsBaton *baton)
     if (dpiStmt_executeMany(baton->dpiStmtHandle, mode,
             baton->bindArraySize) < 0)
         return njsBaton_setErrorDPI(baton);
+    dpiContext_getError(baton->globals->context, &baton->warningInfo);
 
     // process any LOBS for out binds, as needed
     if (dpiStmt_getRowCount(baton->dpiStmtHandle, &baton->rowsAffected) < 0)
@@ -878,7 +879,7 @@ static bool njsConnection_executeManyPostAsync(njsBaton *baton, napi_env env,
         napi_value *result)
 {
     uint32_t numOutBinds;
-    napi_value temp;
+    napi_value temp, error;
 
     // set JavaScript values to simplify creation of returned objects
     if (!njsBaton_setJsValues(baton, env))
@@ -887,6 +888,14 @@ static bool njsConnection_executeManyPostAsync(njsBaton *baton, napi_env env,
     // create object for result
     NJS_CHECK_NAPI(env, napi_create_object(env, result))
 
+    // process warnings if any
+    if (baton->warningInfo.isWarning) {
+        if (!njsUtils_getError(env, &baton->warningInfo, NULL, &error))
+            return false;
+        NJS_CHECK_NAPI(env, napi_set_named_property(env, *result, "warning",
+                                                    error))
+    }
+
     // get out binds
     numOutBinds = njsBaton_getNumOutBinds(baton);
     if (numOutBinds > 0) {

test/list.txt

@@ -5637,3 +5637,5 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
     293.2 Warning from PL/SQL query on a non-existing table
     293.3 Warning from function in a PLSQL query
     293.4 with poolMin=0 with password in grace time with heterogeneous pool
+    293.5 Warning from executeMany
+

test/plsqlWarnings.js

@@ -1,4 +1,4 @@
-/* Copyright (c) 2023, Oracle and/or its affiliates. */
+/* Copyright (c) 2023, 2024, Oracle and/or its affiliates. */
 
 /******************************************************************************
  *
@@ -103,4 +103,20 @@ describe('293. plsqlWarnings.js', function() {
                     end;`);
     assert.strictEqual(result.warning.code.startsWith("NJS-700"), true);
   }); // 293.4
+
+  it('293.5 Warning from executeMany', async () => {
+    const plsql = `
+      CREATE OR REPLACE PROCEDURE nodb_proc_em2() AS
+      BEGIN
+        NULL
+      END nodb_proc_em2;
+    `;
+    const conn = await oracledb.getConnection(dbConfig);
+    const result = await conn.executeMany(plsql, 1);
+
+    assert.strictEqual(result.warning.message.startsWith("NJS-700:"), true);
+
+    await conn.execute(`DROP PROCEDURE nodb_proc_em2`);
+    await conn.close();
+  });   // 293.5
 });