Skip to content

Commit 79a8473

Browse files
committed
More streamNumRows removal in tests
1 parent 510012a commit 79a8473

File tree

2 files changed

+4
-37
lines changed

2 files changed

+4
-37
lines changed

test/list.txt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,7 @@
238238
13.1.8 Read CLOBs
239239
13.1.9 Read CLOBs after stream close
240240
13.1.10 meta data
241-
13.1.11 stream results with bulk size set
242-
13.1.12 stream stress test
241+
13.1.11 stream stress test
243242

244243
14. stream2.js
245244
14.1 Bind by position and return an array
@@ -251,10 +250,6 @@
251250
14.7 Negative - queryStream() has no parameters
252251
14.8 Negative - give invalid SQL as first parameter
253252
14.9 Negatvie - give non-query SQL
254-
- 14.10 Negative - set streamNumRows to be 0
255-
- 14.11 Negative - set streamNumRows to be NaN
256-
14.12 Negative - set streamNumRows to be a negative number
257-
14.13 Negative - set streamNumRows to be a string
258253

259254
21. datatypeAssist.js
260255

test/stream1.js

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -428,38 +428,12 @@ describe('13. stream1.js', function () {
428428
});
429429
});
430430

431-
it('13.1.11 stream results with bulk size set', function (done) {
432-
connection.should.be.ok;
433-
434-
var stream = connection.queryStream('SELECT employees_name FROM nodb_employees', [], {
435-
streamNumRows: 1
436-
});
437-
438-
stream.on('error', function (error) {
439-
should.fail(error, null, 'Error event should not be triggered');
440-
});
441-
442-
var counter = 0;
443-
stream.on('data', function (data) {
444-
should.exist(data);
445-
counter++;
446-
});
447-
448-
stream.on('end', function () {
449-
should.equal(counter, rowsAmount);
450-
451-
setTimeout(done, 500);
452-
});
453-
});
454-
455-
it('13.1.12 stream stress test', function (done) {
431+
it('13.1.11 stream stress test', function (done) {
456432
this.timeout(30000);
457433

458434
connection.should.be.ok;
459435

460-
var stream = connection.queryStream('SELECT employees_name FROM nodb_employees', [], {
461-
streamNumRows: 1
462-
});
436+
var stream = connection.queryStream('SELECT employees_name FROM nodb_employees');
463437

464438
stream.on('error', function (error) {
465439
should.fail(error, null, 'Error event should not be triggered');
@@ -478,9 +452,7 @@ describe('13. stream1.js', function () {
478452

479453
var testDone = 0;
480454
var subTest = function (callback) {
481-
var query = connection.queryStream('SELECT employees_name FROM nodb_employees', [], {
482-
streamNumRows: Math.floor((Math.random() * (500 - 1)) + 1)
483-
});
455+
var query = connection.queryStream('SELECT employees_name FROM nodb_employees');
484456

485457
query.on('error', function (error) {
486458
should.fail(error, null, 'Error event should not be triggered');

0 commit comments

Comments
 (0)