Fixed regression with getStatementInfo() metadata

Author: cjbj

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## node-oracledb v4.0.1 (DD MON YYYY)
 
+- Fixed a regression with missing `metaData` from `connection.getStatementInfo()`
+
 - Fixed passing DbObjects and JavaScript objects as the `payload` attribute for
   AQ message enqueues when using an object queue.
 

src/njsConnection.c

@@ -1759,12 +1759,24 @@ static bool njsConnection_getStatementInfoAsync(njsBaton *baton)
 static bool njsConnection_getStatementInfoPostAsync(njsBaton *baton,
         napi_env env, napi_value *args)
 {
-    napi_value result, bindNames, temp;
+    napi_value result, bindNames, metadata, temp;
     uint32_t i;
 
     // create object for the result
     NJS_CHECK_NAPI(env, napi_create_object(env, &result))
 
+    // add metadata (queries only)
+    if (baton->queryVars) {
+        if (!njsVariable_initForQueryJS(baton->queryVars, baton->numQueryVars,
+                env, baton))
+            return false;
+        if (!njsVariable_getMetadataMany(baton->queryVars, baton->numQueryVars,
+                env, baton->extendedMetaData, &metadata))
+            return false;
+        NJS_CHECK_NAPI(env, napi_set_named_property(env, result, "metaData",
+                metadata))
+    }
+
     // add array for the bind names
     NJS_CHECK_NAPI(env, napi_create_array_with_length(env, baton->numBindNames,
             &bindNames))

test/getStmtInfo.js

@@ -85,9 +85,20 @@ describe('162. getStmtInfo.js', function() {
       sql,
       function(err, info) {
         should.not.exist(err);
-        should.exist(info);
-        should.deepEqual(info.bindNames, []);
-        should.strictEqual(info.statementType, oracledb.STMT_TYPE_SELECT);
+        should.deepEqual(info,
+          { bindNames: [], statementType: oracledb.STMT_TYPE_SELECT,
+            metaData: [
+              {
+                dbType: oracledb.DB_TYPE_NUMBER,
+                dbTypeName: "NUMBER",
+                fetchType: oracledb.DB_TYPE_NUMBER,
+                name: "COL",
+                nullable: true,
+                precision: 0,
+                scale: -127
+              }
+            ]
+          });
         done();
       }
     );
@@ -517,4 +528,4 @@ describe('162. getStmtInfo.js', function() {
     );
   });
 
-});
+});