Skip to content

Commit 7cb3cae

Browse files
committed
Fixed bug that did not allow connection to Oracle Database 23ai instances that have fast authentication disabled
1 parent 46d3e08 commit 7cb3cae

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

doc/src/release_notes.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ Common Changes
1616
Thin Mode Changes
1717
+++++++++++++++++
1818

19+
#) Fixed bug that did not allow connection to Oracle Database 23ai instances
20+
that have fast authentication disabled.
21+
1922
#) Fixed bug with statement cache which threw an `NJS-111` error when select
2023
SQL is run on CLOB columns fetched as string.
2124
See `Issue #1684 <https://github.com/oracle/node-oracledb/issues/

lib/thin/connection.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -797,8 +797,14 @@ class ThinConnectionImpl extends ConnectionImpl {
797797
await this._protocol._processMessage(authMessage);
798798
}
799799
} else {
800+
// When Fast Auth is explicitly disabled on servers > 23ai,
801+
// we dont rely on message type TNS_MSG_TYPE_END_OF_REQUEST too
802+
// for protocolMessage and dataTypeMessage.
803+
const endOfRequestSupport = this.nscon.endOfRequestSupport;
804+
this.nscon.endOfRequestSupport = false;
800805
await this._protocol._processMessage(protocolMessage);
801806
await this._protocol._processMessage(dataTypeMessage);
807+
this.nscon.endOfRequestSupport = endOfRequestSupport;
802808
await this._protocol._processMessage(authMessage);
803809
}
804810
if (!params.token) { // non-token Authentication

0 commit comments

Comments
 (0)