Add PL/SQL Index-by array tests

Author: cjbj

test/list.txt

@@ -418,29 +418,34 @@
         43.2.2 maxArraySize is mandatory for BIND_INOUT
         42.2.3 maxArraySize cannot smaller than the number of array elements
         42.2.4 DATE type has not been supported yet
-        42.2.5 the type of the array element should be compatible with binding type declaration
-        42.2.6 type compatibility
-        42.2.7 dose not allow array syntax of bindings
+        42.2.5 negative case (string): incorrect type of array element
+        42.2.6 negative case (number): incorrect type of array element
+        42.2.7 supports binding by position
     43.3 binding PL/SQL scalar
         43.3.1 binding PL/SQL scalar IN 
       - 43.3.2 binding PL/SQL scalar IN/OUT
-        43.3.3 binding PL/SQL scalar OUT
+        43.3.3 binding PL/SQL scalar OUT by name
+        43.3.4 binding PL/SQL scalar OUT by position
     43.4 test attribute - maxArraySize
         43.4.1 maxArraySize property is ignored for BIND_IN
         43.4.2 maxArraySize is mandatory for BIND_INOUT
         43.4.3 maxArraySize cannot smaller than the number of array elements
         43.4.4 maxArraySize can be equal to the number of array elements
       - 43.4.5 negative case: large value
-        43.4.6 negative case: <0
+        43.4.6 negative case: < 0
         43.4.7 negative case: = 0
-        43.4.8 negative case: assigning it to be a string
+        43.4.8 negative case: assigning a string to it
         43.4.9 negative case: NaN
 
 44. plsqlBinding2.js
     44.1 example case
-    44.2 null elements in String and Number arrays
-    44.3 NJS-039: empty array is not allowed for IN bind
-    - 44.4 maxSize option applies to each elements of an array
+    44.2 example case binding by position
+  - 44.3 default binding type and direction with binding by name
+    44.4 default binding type and direction with binding by position
+    44.5 null elements in String and Number arrays
+    44.6 NJS-039: empty array is not allowed for IN bind
+  - 44.7 maxSize option applies to each elements of an array
+
 
 51. accessTerminatedPoolAttributes.js
     can not access attributes of terminated pool

test/plsqlBinding1.js

@@ -427,7 +427,7 @@ describe('43. plsqlBinding1.js', function() {
       );
     })
 
-    it('42.2.5 the type of the array element should be compatible with binding type declaration', function(done) {
+    it('42.2.5 negative case (string): incorrect type of array elements', function(done) {
       var bindvars = {
         p:  {type: oracledb.STRING, dir: oracledb.BIND_IN, val: ['hello', 1]}
       };
@@ -444,7 +444,7 @@ describe('43. plsqlBinding1.js', function() {
       );
     })
 
-    it('42.2.6 type compatibility', function(done) {
+    it('42.2.6 negative case (number): incorrect type of array element', function(done) {
       var bindvars = {
         p:  {type: oracledb.NUMBER, dir: oracledb.BIND_IN, val: [1, 'hello']}
       };
@@ -461,7 +461,7 @@ describe('43. plsqlBinding1.js', function() {
       );
     })
 
-    it('42.2.7 dose not allow array syntax of bindings', function(done) {
+    it('42.2.7 supports binding by position', function(done) {
       var bindvars = [
         {type: oracledb.STRING, dir: oracledb.BIND_IN, val: ['hello', 'node.js']}
       ];
@@ -578,7 +578,7 @@ describe('43. plsqlBinding1.js', function() {
             bindvars,
             function(err, result) {
               should.not.exist(err);
-              console.log(result);
+              // console.log(result);
               result.outBinds.stringValue.should.be.exactly('(Space odyssey)');
               result.outBinds.numberValue.should.be.exactly(2101);
               //result.outBinds.dateValue.should.eql(releaseDate)
@@ -598,7 +598,7 @@ describe('43. plsqlBinding1.js', function() {
       ], done);
     });
 
-    it('43.3.3 binding PL/SQL scalar OUT', function(done) {
+    it('43.3.3 binding PL/SQL scalar OUT by name', function(done) {
       async.series([
         function(callback) {
           var proc = "CREATE OR REPLACE\n" +
@@ -632,7 +632,7 @@ describe('43. plsqlBinding1.js', function() {
               // console.log(result);
               result.outBinds.stringValue.should.be.exactly('Space odyssey');
               result.outBinds.numberValue.should.be.exactly(2001);
-              (typeof (result.outBinds.dateValue)).should.eql('object');
+              (Object.prototype.toString.call(result.outBinds.dateValue)).should.eql('[object Date]');
               callback();
             }
           );
@@ -649,6 +649,57 @@ describe('43. plsqlBinding1.js', function() {
       ], done);
     });
 
+    it('43.3.4 binding PL/SQL scalar OUT by postion', function(done) {
+      async.series([
+        function(callback) {
+          var proc = "CREATE OR REPLACE\n" +
+                     "PROCEDURE test(stringValue OUT VARCHAR2, numberValue OUT NUMBER, dateValue OUT DATE)\n" +
+                     "IS\n" +
+                     "BEGIN\n" +
+                     "  stringValue := 'Space odyssey';\n" +
+                     "  numberValue := 2001;\n" +
+                     "  dateValue   := TO_DATE('04-02-1968', 'MM-DD-YYYY');" + 
+                     "END test;\n";
+          connection.should.be.ok;
+          connection.execute(
+            proc,
+            function(err) {
+              should.not.exist(err);
+              callback();
+            }
+          );
+        },
+        function(callback) {
+          var bindvars = [
+            {type: oracledb.STRING, dir: oracledb.BIND_OUT},
+            {type: oracledb.NUMBER, dir: oracledb.BIND_OUT},
+            {type: oracledb.DATE, dir: oracledb.BIND_OUT}
+          ];
+          connection.execute(
+            "BEGIN test(:1, :2, :3); END;",
+            bindvars,
+            function(err, result) {
+              should.not.exist(err);
+              // console.log(result);
+              result.outBinds[0].should.be.exactly('Space odyssey');
+              result.outBinds[1].should.be.exactly(2001);
+              (Object.prototype.toString.call(result.outBinds[2])).should.eql('[object Date]');
+              callback();
+            }
+          );
+        },
+        function(callback) {
+          connection.execute(
+            "DROP PROCEDURE test",
+            function(err) {
+              should.not.exist(err);
+              callback();
+            }
+          );
+        }
+      ], done);
+    })
+
   }) // 43.3
 
   describe('43.4 test attribute - maxArraySize', function() {
@@ -805,7 +856,7 @@ describe('43. plsqlBinding1.js', function() {
       );
     })
 
-    it('43.4.6 negative case: <0', function(done) {
+    it('43.4.6 negative case: < 0', function(done) {
       var bindvars = {
         p:  {type: oracledb.NUMBER, dir: oracledb.BIND_INOUT, val: [1, 2, 3], maxArraySize: -9}
       };
@@ -837,7 +888,7 @@ describe('43. plsqlBinding1.js', function() {
       );
     })
 
-    it('43.4.8 negative case: assigning it to be a string', function(done) {
+    it('43.4.8 negative case: assign a string to it', function(done) {
       var bindvars = {
         p:  {type: oracledb.NUMBER, dir: oracledb.BIND_INOUT, val: [1, 2, 3], maxArraySize: 'foobar'}
       };