Perform initialization of all scalar values in constructors

Author: cjbj

src/njsCommon.h

@@ -169,8 +169,12 @@ class njsVariable {
     uint32_t numQueryVars;
     njsVariable *queryVars;
 
-    njsVariable() : dpiVarHandle(NULL), dpiVarData(NULL), lobs(NULL),
-            queryVars(NULL) {}
+    njsVariable() : pos(0), dbTypeNum(DPI_ORACLE_TYPE_VARCHAR),
+            varTypeNum(DPI_ORACLE_TYPE_VARCHAR),
+            nativeTypeNum(DPI_NATIVE_TYPE_BYTES), dpiVarHandle(NULL),
+            dpiVarData(NULL), bindDir(0), maxArraySize(0), maxSize(0),
+            dbSizeInBytes(0), precision(0), scale(0), isArray(false),
+            isNullable(false), lobs(NULL), numQueryVars(0), queryVars(NULL) {}
     ~njsVariable();
     njsDataType DataType();
     njsDBType DBType();
@@ -293,14 +297,18 @@ class njsBaton {
     Nan::Persistent<Function> jsCallback;
 
     njsBaton(Local<Function> callback, Local<Object> callingObj) :
-            dpiPoolHandle(NULL), dpiConnHandle(NULL), dpiStmtHandle(NULL),
-            dpiLobHandle(NULL), maxRows(0), numQueryVars(0), queryVars(NULL),
-            numBindVars(0), bindVars(NULL), numFetchInfo(0), fetchInfo(NULL),
-            numFetchAsStringTypes(0), fetchAsStringTypes(NULL),
-            numFetchAsBufferTypes(0), fetchAsBufferTypes(NULL),
-            protoILob(NULL), keepQueryInfo(false), isReturning(false),
-            bufferSize(0), bufferPtr(NULL), lobOffset(0), lobAmount(0)
-    {
+            poolMin(0), poolMax(0), poolIncrement(0), poolTimeout(0),
+            poolPingInterval(0), dpiPoolHandle(NULL), dpiConnHandle(NULL),
+            dpiStmtHandle(NULL), dpiLobHandle(NULL), stmtCacheSize(0),
+            lobPrefetchSize(0), maxRows(0), fetchArraySize(0), rowsFetched(0),
+            bufferRowIndex(0), rowsAffected(0), outFormat(0), numQueryVars(0),
+            queryVars(NULL), numBindVars(0), bindVars(NULL), numFetchInfo(0),
+            fetchInfo(NULL), numFetchAsStringTypes(0),
+            fetchAsStringTypes(NULL), numFetchAsBufferTypes(0),
+            fetchAsBufferTypes(NULL), protoILob(NULL), externalAuth(false),
+            getRS(false), autoCommit(false), extendedMetaData(false),
+            keepQueryInfo(false), isReturning(false), isPLSQL(false),
+            bufferSize(0), bufferPtr(NULL), lobOffset(0), lobAmount(0) {
         this->jsCallback.Reset(callback);
         this->jsCallingObj.Reset(callingObj);
         this->callingObj = Nan::ObjectWrap::Unwrap<njsCommon>(callingObj);

src/njsIntLob.h

@@ -76,7 +76,8 @@ friend class njsILob;
 friend class njsConnection;
 public:
 
-    njsProtoILob() : dpiLobHandle(NULL) {}
+    njsProtoILob() : dpiLobHandle(NULL), dataType(NJS_DATATYPE_DEFAULT),
+            chunkSize(0), length(0), isAutoClose(false) {}
     ~njsProtoILob() {
         if (dpiLobHandle) {
             dpiLob_release(dpiLobHandle);
@@ -112,7 +113,9 @@ class njsILob : public njsCommon {
     static bool HasInstance(Local<Value> val);
 
 private:
-    njsILob() : dpiLobHandle(NULL), bufferPtr(NULL) {}
+    njsILob() : dpiLobHandle(NULL), dataType(NJS_DATATYPE_DEFAULT),
+            bufferPtr(NULL), isAutoClose(false), pieceSize(0), chunkSize(0),
+            length(0), offset(0) {}
     ~njsILob() {
         if (dpiLobHandle) {
             dpiLob_release(dpiLobHandle);

src/njsOracle.cpp

@@ -62,7 +62,7 @@
 Nan::Persistent<FunctionTemplate> njsOracledb::oracledbTemplate_s;
 
 // DPI context
-dpiContext *njsOracledb::globalDPIContext;
+dpiContext *njsOracledb::globalDPIContext = NULL;
 
 // common pool/standalone connection creation parameters (fixed)
 dpiCommonCreateParams njsCommonCreateParams;
@@ -88,6 +88,7 @@ njsOracledb::njsOracledb()
     externalAuth            = false;
     lobPrefetchSize         = NJS_LOB_PREFETCH_SIZE;
     poolPingInterval        = NJS_POOL_DEFAULT_PING_INTERVAL;
+    oraClientVer            = 0;
 }
 
 

src/njsPool.h

@@ -105,7 +105,9 @@ class njsPool: public njsCommon {
     static NAN_SETTER(SetConnectionsInUse);
     static NAN_SETTER(SetStmtCacheSize);
 
-    njsPool() : dpiPoolHandle(NULL) {}
+    njsPool() : dpiPoolHandle(NULL), poolMin(0), poolMax(0), poolIncrement(0),
+            poolTimeout(0), stmtCacheSize(0), lobPrefetchSize(0),
+            poolPingInterval(0) {}
     ~njsPool() {
         jsOracledb.Reset();
         if (dpiPoolHandle) {

src/njsResultSet.h

@@ -78,7 +78,8 @@ class njsResultSet: public njsCommon {
 
 private:
 
-    njsResultSet() : dpiStmtHandle(NULL), numQueryVars(0), queryVars(NULL) {}
+    njsResultSet() : dpiStmtHandle(NULL), dpiConnHandle(NULL), numQueryVars(0),
+            queryVars(NULL), outFormat(0), extendedMetaData(false) {}
     ~njsResultSet();
 
     static NAN_METHOD(New);