Skip to content

Commit 89b5746

Browse files
committed
Note the UV_THREADPOOL_SIZE limit change in 12.6
1 parent 44751d7 commit 89b5746

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

doc/api.md

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1437,10 +1437,9 @@ The default value is 4.
14371437

14381438
This property may be overridden when [creating a connection pool](#createpool).
14391439

1440-
See [Connections and Number of Threads](#numberofthreads) for why you
1441-
should not increase this value beyond 128. Importantly, if you
1442-
increase `poolMax` you should also increase the number of threads
1443-
available to node-oracledb.
1440+
Importantly, if you increase `poolMax` you should also increase the
1441+
number of threads available to node-oracledb. See [Connections and
1442+
Number of Threads](#numberofthreads).
14441443

14451444
See [Connection Pooling](#connpooling) for other pool sizing guidelines.
14461445

@@ -1904,10 +1903,9 @@ The default value is 4.
19041903
This optional property overrides the
19051904
[`oracledb.poolMax`](#propdbpoolmax) property.
19061905

1907-
See [Connections and Number of Threads](#numberofthreads) for why you
1908-
should not increase this value beyond 128. Importantly, if you
1909-
increase `poolMax` you should also increase the number of threads
1910-
available to node-oracledb.
1906+
Importantly, if you increase `poolMax` you should also increase the
1907+
number of threads available to node-oracledb. See [Connections and
1908+
Number of Threads](#numberofthreads).
19111909

19121910
See [Connection Pooling](#connpooling) for other pool sizing guidelines.
19131911

@@ -7011,9 +7009,12 @@ If the value is set inside the application with
70117009
asynchronous call that uses the thread pool otherwise the default size
70127010
of 4 will still be used.
70137011

7014-
Note the '[libuv][21]' library used by Node.js limits the number of
7015-
threads to 128. This implies the maximum number of connections
7016-
opened, i.e. `poolMax`, should be less than 128.
7012+
Note the '[libuv][21]' library used by Node.js 12.5 and earlier limits
7013+
the number of threads to 128. In Node.js 12.6 onward the limit
7014+
is 1024. You should restrict the maximum number of connections opened
7015+
in an application, i.e. `poolMax`, to a value lower than the
7016+
`UV_THREADPOOL_SIZE` limit. If you have multiple pools, make sure the
7017+
sum of all `poolMax` values is no larger than `UV_THREADPOOL_SIZE`.
70177018

70187019
Connections can handle one database operation at a time. Node.js
70197020
worker threads executing database statements on a connection will wait
@@ -7138,9 +7139,7 @@ should be [executed sequentially, not in parallel](#numberofthreads)
71387139
on each connection.
71397140

71407141
If you increase the size of the pool, you must [increase the number of
7141-
threads](#numberofthreads) used by Node.js. Since the number of
7142-
threads available to Node.js is at most 128, this implies that
7143-
`poolMax` should be less than 128.
7142+
threads](#numberofthreads) used by Node.js.
71447143

71457144
The growth characteristics of a connection pool are determined by the
71467145
Pool attributes [`poolIncrement`](#proppoolpoolincrement),

0 commit comments

Comments
 (0)