Skip to content

Commit 902e4db

Browse files
committed
Internal Code and Doc formatting updates
1 parent 668ccb3 commit 902e4db

File tree

3 files changed

+31
-27
lines changed

3 files changed

+31
-27
lines changed

doc/src/release_notes.rst

Lines changed: 27 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,35 +13,37 @@ node-oracledb `v6.7.0 <https://github.com/oracle/node-oracledb/compare/v6.6.0...
1313
Common Changes
1414
++++++++++++++
1515

16-
#) Added internal code changes to validate the updated OCI centralized
17-
configuration provider URL syntax.
18-
19-
#) Added support to enable tracing with the OpenTelemetry
20-
module for Oracle Database being created in the OpenTelemetry project.
21-
22-
#) Added support to connect to Oracle Database using wallets stored in
23-
Azure Key Vault and OCI Vault.
24-
25-
#) Added ability to cache the configuration information retrieved from
26-
:ref:`Azure App Configuration <conninfocacheazure>` and
27-
:ref:`OCI Object Storage <conninfocacheoci>` centralized configuration
28-
providers.
29-
30-
#) Ensure that the password stored in OCI vault and retrieved
31-
in base64-encoded format is decoded correctly.
16+
#) Added tracing functionality for OpenTelemetry support.
3217

3318
#) Changed default values of ``transportConnectTimeout`` and
3419
``retryDelay`` properties to *20* seconds and *1* second respectively in
3520
:meth:`oracledb.getConnection()` and :meth:`oracledb.createPool()` for
3621
consistency with other Oracle Database drivers.
3722

38-
#) Changed the password type parameter values from `vault-oci` and
39-
`vault-azure` to `ocivault` and `azurevault` respectively for consistency
40-
with other Oracle Database drivers.
41-
4223
#) Added method :meth:`oracledb.getNetworkServiceNames()` to support fetching
4324
the list of network service names from the ``tnsnames.ora`` file.
4425

26+
#) Improvements to Centralized Configuration Providers support:
27+
28+
- Added support to connect to Oracle Database via the centralized
29+
configuration providers using wallets stored in Azure Key Vault and
30+
OCI Vault.
31+
32+
- Added ability to cache the configuration information retrieved from
33+
:ref:`Azure App Configuration <conninfocacheazure>` and
34+
:ref:`OCI Object Storage <conninfocacheoci>` centralized configuration
35+
providers.
36+
37+
- Ensure that the password stored in OCI vault and retrieved in
38+
base64-encoded format is decoded correctly.
39+
40+
- Added internal code changes to validate the updated OCI centralized
41+
configuration provider URL syntax.
42+
43+
- Changed the password type parameter values from `vault-oci` and
44+
`vault-azure` to `ocivault` and `azurevault` respectively for consistency
45+
with other Oracle Database drivers.
46+
4547
#) Remove the 'Critical Dependency' warning from webpack builds.
4648
See `Issue #1678 <https://github.com/oracle/node-oracledb/issues/1678>`__.
4749

@@ -54,14 +56,16 @@ Thin Mode Changes
5456

5557
#) Fixed bug that did not allow connection to Oracle Database 23ai instances
5658
that have fast authentication disabled.
59+
See `Issue #1697<https://github.com/oracle/node-oracledb/issues/1697>`__.
5760

5861
#) Fixed bug with statement cache which threw an ``NJS-111`` error when select
5962
SQL is run on CLOB columns fetched as string.
6063
See `Issue #1684 <https://github.com/oracle/node-oracledb/issues/
6164
1684>`__.
6265

63-
#) Added new properties in `oracledb` that can enable users to customize and set session information,
64-
making it easier to manage and monitor database interactions.
66+
#) Added new properties in `oracledb` that can enable users to customize and
67+
set session information, making it easier to manage and monitor database
68+
interactions.
6569

6670
#) Error ``NJS-125`` is now raised when an empty connect string is provided
6771
for creating pools.
@@ -2375,7 +2379,7 @@ node-oracledb `v1.10.0 <https://github.com/oracle/node-oracledb/compare/v1.9.3..
23752379

23762380
#) Added GitHub Issue and Pull Request templates.
23772381

2378-
#) Some enhancements were made to the underlying DPI data access layer.
2382+
#) Some enhancements were made to the underlying ODPI data access layer.
23792383
**These are not exposed to node-oracledb users.**
23802384

23812385
- Allow SYSDBA connections

lib/configProviders/azure.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ class AzureProvider extends base {
4040
//---------------------------------------------------------------------------
4141
// init()
4242
//
43-
// Require/import modules from azure
43+
// Require/import modules from Azure SDK
4444
//---------------------------------------------------------------------------
4545
init() {
46-
({AppConfigurationClient } = require("@azure/app-configuration"));
47-
({ClientSecretCredential, ClientCertificateCredential, ChainedTokenCredential, ManagedIdentityCredential, EnvironmentCredential} = require("@azure/identity"));
46+
({ AppConfigurationClient } = require("@azure/app-configuration"));
47+
({ ClientSecretCredential, ClientCertificateCredential, ChainedTokenCredential, ManagedIdentityCredential, EnvironmentCredential } = require("@azure/identity"));
4848
}
4949

5050
//---------------------------------------------------------------------------

lib/errors.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ messages.set(ERR_UNKNOWN_TRANSACTION_STATE, // NJS-152
457457
'internal error: unknown transaction state {state} in Two Phase Commit');
458458
messages.set(ERR_INVALID_TRANSACTION_SIZE, // NJS-153
459459
'size of the transaction ID is %d and cannot exceed 64');
460-
messages.set(ERR_INVALID_BRANCH_SIZE, // NJS-154
460+
messages.set(ERR_INVALID_BRANCH_SIZE, // NJS-154
461461
'size of the branch ID is %d and cannot exceed 64');
462462
messages.set(ERR_OPERATION_NOT_SUPPORTED_ON_BFILE, // NJS-155
463463
'operation is not supported on BFILE LOBs');

0 commit comments

Comments
 (0)