Skip to content

Commit 91337fa

Browse files
committed
Remove redundant 'agent' parameter
1 parent 0da2dfd commit 91337fa

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

package/oracledbinstall.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
* pre-built node-oracleb binary from GitHub if one is available, or
2525
* gives a message on how to compile one from source code.
2626
*
27+
* Set NODE_ORACLEDB_TRACE_INSTALL=TRUE for installation trace output.
28+
*
2729
* MAINTENANCE NOTES
2830
* - This file should run with Node 4 or later.
2931
* - This file should only ever 'require' packages included in core Node.js.
@@ -216,7 +218,7 @@ function getFileReadStreamByProxy(hostname, path, proxyHostname, proxyPort) {
216218
reject(new Error('Error: HTTP proxy request for ' + hostname + path + ' failed with code ' + res.statusCode));
217219
return;
218220
} else {
219-
getFileReadStreamBase(hostname, path, socket, false)
221+
getFileReadStreamBase(hostname, path, socket)
220222
.then(fileReadStream => {
221223
resolve(fileReadStream);
222224
})
@@ -228,7 +230,7 @@ function getFileReadStreamByProxy(hostname, path, proxyHostname, proxyPort) {
228230

229231
// The getFileReadStreamBase function is the main function that retrieves a remote
230232
// file read stream.
231-
function getFileReadStreamBase(hostname, path, socket, agent) {
233+
function getFileReadStreamBase(hostname, path, socket) {
232234
return new Promise((resolve, reject) => {
233235
packageUtil.trace('In getFileReadStreamBase', hostname, path);
234236

@@ -238,8 +240,7 @@ function getFileReadStreamBase(hostname, path, socket, agent) {
238240
{
239241
host: hostname,
240242
path: path,
241-
socket: socket,
242-
agent: agent
243+
socket: socket
243244
},
244245
function(res) {
245246
packageUtil.trace('HTTP statusCode =', res.statusCode);

0 commit comments

Comments
 (0)