Skip to content

Commit 93a4835

Browse files
committed
Eliminate static analysis warnings
1 parent 3d01315 commit 93a4835

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/njsConnection.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1457,7 +1457,6 @@ static napi_value njsConnection_getOracleServerVersionString(napi_env env,
14571457
uint32_t releaseStringLength;
14581458
dpiVersionInfo versionInfo;
14591459
const char *releaseString;
1460-
int versionStringLength;
14611460
char versionString[40];
14621461
njsConnection *conn;
14631462

@@ -1470,12 +1469,11 @@ static napi_value njsConnection_getOracleServerVersionString(napi_env env,
14701469
njsUtils_throwErrorDPI(env, conn->oracleDb);
14711470
return NULL;
14721471
}
1473-
versionStringLength = sprintf(versionString, "%d.%d.%d.%d.%d",
1472+
(void) snprintf(versionString, sizeof(versionString), "%d.%d.%d.%d.%d",
14741473
versionInfo.versionNum, versionInfo.releaseNum,
14751474
versionInfo.updateNum, versionInfo.portReleaseNum,
14761475
versionInfo.portUpdateNum);
1477-
return njsUtils_convertToString(env, versionString,
1478-
(uint32_t) versionStringLength);
1476+
return njsUtils_convertToString(env, versionString, strlen(versionString));
14791477
}
14801478

14811479

src/njsOracleDb.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -876,9 +876,10 @@ static napi_value njsOracleDb_getOracleClientVersionString(napi_env env,
876876
njsUtils_throwErrorDPI(env, oracleDb);
877877
return NULL;
878878
}
879-
(void) sprintf(versionString, "%d.%d.%d.%d.%d", versionInfo.versionNum,
880-
versionInfo.releaseNum, versionInfo.updateNum,
881-
versionInfo.portReleaseNum, versionInfo.portUpdateNum);
879+
(void) snprintf(versionString, sizeof(versionString), "%d.%d.%d.%d.%d",
880+
versionInfo.versionNum, versionInfo.releaseNum,
881+
versionInfo.updateNum, versionInfo.portReleaseNum,
882+
versionInfo.portUpdateNum);
882883
return njsUtils_convertToString(env, versionString, strlen(versionString));
883884
}
884885

0 commit comments

Comments
 (0)