Skip to content

Commit 9682097

Browse files
committed
Delete unstable test that tried to close temp LOB concurrently
1 parent 2b62775 commit 9682097

File tree

2 files changed

+3
-66
lines changed

2 files changed

+3
-66
lines changed

test/list.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1083,8 +1083,7 @@ Overview of node-oracledb functional tests
10831083
72.2.3 Negative - inconsistent datatypes
10841084
72.2.4 Negative - not providing first parameter
10851085
72.2.5 promise test of createLob()
1086-
72.2.6 Negative - call lob.close() twice concurrently
1087-
72.2.7 call lob.close() multiple times sequentially
1086+
72.2.6 call lob.close() multiple times sequentially
10881087

10891088
73. poolPing.js
10901089
73.1 the default value of poolPingInterval is 60

test/lobBind2.js

Lines changed: 2 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -822,69 +822,7 @@ describe("72. lobBind2.js", function() {
822822

823823
}); // 72.2.5
824824

825-
it("72.2.6 Negative - call lob.close() twice concurrently", function(done) {
826-
827-
var seq = 6000;
828-
829-
async.series([
830-
function(cb) {
831-
connection.createLob(oracledb.BLOB, function(err, lob) {
832-
should.not.exist(err);
833-
834-
lob.on("close", function(err) {
835-
should.not.exist(err);
836-
837-
connection.commit(function(err) {
838-
should.not.exist(err);
839-
840-
return cb();
841-
});
842-
}); // close event
843-
844-
lob.on("error", function(err) {
845-
should.not.exist(err, "lob.on 'error' event.");
846-
});
847-
848-
lob.on("finish", function() {
849-
connection.execute(
850-
"insert into nodb_tab_blob72 (id, content) values (:id, :bindvar)",
851-
{ id: seq, bindvar: lob},
852-
function(err, result) {
853-
should.not.exist(err);
854-
855-
should.strictEqual(result.rowsAffected, 1);
856-
857-
lob.close(function(err) {
858-
should.not.exist(err);
859-
});
860-
861-
lob.close(function(err) {
862-
should.exist(err);
863-
(err.message).should.startWith("NJS-023:");
864-
// NJS-023: concurrent operations on a Lob are not allowed
865-
});
866-
}
867-
);
868-
}); // finish event
869-
870-
var inStream = fs.createReadStream(jpgFileName);
871-
872-
inStream.on("error", function(err) {
873-
should.not.exist(err, "inStream.on 'error' event.");
874-
});
875-
876-
inStream.pipe(lob);
877-
878-
}); // createLob()
879-
},
880-
function(cb) {
881-
verifyBlobValue(seq, jpgFileName, cb);
882-
}
883-
], done);
884-
885-
}); // 72.2.6
886-
887-
it("72.2.7 call lob.close() multiple times sequentially", function(done) {
825+
it("72.2.6 call lob.close() multiple times sequentially", function(done) {
888826

889827
var seq = 7000;
890828

@@ -942,7 +880,7 @@ describe("72. lobBind2.js", function() {
942880
}
943881
], done);
944882

945-
}); // 72.2.7
883+
}); // 72.2.6
946884

947885
}); // 72.2
948886

0 commit comments

Comments
 (0)