Consistently use return for async callbacks

Author: cjbj

examples/date.js

@@ -127,7 +127,7 @@ var doselect = function(conn, cb) {
       d.setDate(d.getDate() - 5);
       console.log(d);
 
-      cb(null, conn);
+      return cb(null, conn);
     });
 };
 

examples/lobbinds.js

@@ -202,7 +202,7 @@ var query_plsql_inout = function (conn, cb) {
             function(err)
             {
               // console.log("clob2.on 'error' event");
-              cb(err);
+              return cb(err);
             });
           clob2.on(
             'end',
@@ -226,7 +226,7 @@ var query_plsql_inout = function (conn, cb) {
             function(err)
             {
               // console.log("outStream.on 'error' event");
-              cb(err);
+              return cb(err);
             });
 
           // Switch into flowing mode and push the LOB to the file
@@ -279,7 +279,7 @@ var plsql_out_inout = function (conn, cb) {
             function(err)
             {
               // console.log("clob2.on 'error' event");
-              cb(err);
+              return cb(err);
             });
           clob2.on(
             'end',
@@ -302,7 +302,7 @@ var plsql_out_inout = function (conn, cb) {
             function(err)
             {
               // console.log("outStream.on 'error' event");
-              cb(err);
+              return cb(err);
             });
 
           // Switch into flowing mode and push the LOB to the file

examples/lobinsert1.js

@@ -85,7 +85,7 @@ var doclobinsert = function(conn, cb) {
         return cb(new Error('Error inserting CLOB'), conn);
       }
       console.log('CLOB inserted from ' + clobInFileName);
-      cb(null, conn);
+      return cb(null, conn);
     });
 };
 
@@ -103,7 +103,7 @@ var doblobinsert = function(conn, cb) {
         return cb(new Error('Error inserting BLOB'), conn);
       }
       console.log('BLOB inserted from ' + blobInFileName);
-      cb(null, conn);
+      return cb(null, conn);
     });
 };
 

examples/lobinserttemp.js

@@ -69,7 +69,7 @@ var docreatetemplob = function (conn, cb) {
       return cb(err);
     }
     console.log("Temporary LOB created with createLob()");
-    cb(null, conn, templob);
+    return cb(null, conn, templob);
   });
 };
 
@@ -87,7 +87,7 @@ var doloadtemplob = function (conn, templob, cb) {
     function(err)
     {
       console.log("templob.on 'error' event");
-      cb(err);
+      return cb(err);
     });
 
   templob.on(
@@ -96,7 +96,7 @@ var doloadtemplob = function (conn, templob, cb) {
     {
       console.log("templob.on 'finish' event");
       // The data was loaded into the temporary LOB
-      cb(null, conn, templob);
+      return cb(null, conn, templob);
     });
 
   console.log('Reading from ' + inFileName);
@@ -106,7 +106,7 @@ var doloadtemplob = function (conn, templob, cb) {
     function(err)
     {
       console.log("inStream.on 'error' event");
-      cb(err);
+      return cb(err);
     });
 
   inStream.pipe(templob);  // copies the text to the temporary LOB

examples/lobplsqltemp.js

@@ -69,7 +69,7 @@ var createtemplob = function (conn, cb) {
       return cb(err);
     }
     console.log("Temporary LOB created with createLob()");
-    cb(null, conn, templob);
+    return cb(null, conn, templob);
   });
 };
 
@@ -87,7 +87,7 @@ var loadtemplob = function (conn, templob, cb) {
     function(err)
     {
       console.log("templob.on 'error' event");
-      cb(err);
+      return cb(err);
     });
 
   templob.on(
@@ -96,7 +96,7 @@ var loadtemplob = function (conn, templob, cb) {
     {
       console.log("templob.on 'finish' event");
       // The data was loaded into the temporary LOB
-      cb(null, conn, templob);
+      return cb(null, conn, templob);
     });
 
   console.log('Reading from ' + inFileName);
@@ -106,7 +106,7 @@ var loadtemplob = function (conn, templob, cb) {
     function(err)
     {
       console.log("inStream.on 'error' event");
-      cb(err);
+      return cb(err);
     });
 
   inStream.pipe(templob);  // copies the text to the temporary LOB

examples/lobstream1.js

@@ -75,7 +75,7 @@ var  dostream = function(lob, cb) {
     function(err)
     {
       // console.log("lob.on 'error' event");
-      cb(err);
+      return cb(err);
     });
   lob.on(
     'end',
@@ -88,7 +88,7 @@ var  dostream = function(lob, cb) {
     function()
     {
       // console.log("lob.on 'close' event");
-      cb(null);
+      return cb(null);
     });
 
   var outStream = fs.createWriteStream(outFileName);
@@ -97,7 +97,7 @@ var  dostream = function(lob, cb) {
     function(err)
     {
       // console.log("outStream.on 'error' event");
-      cb(err);
+      return cb(err);
     });
 
   // Switch into flowing mode and push the LOB to the file
@@ -119,7 +119,7 @@ var doquery = function(cb) {
       if (lob === null) {
         return cb(new Error("LOB was NULL"));
       }
-      cb(null, lob);
+      return cb(null, lob);
     });
 };
 

examples/lobstream2.js

@@ -71,7 +71,7 @@ var doquery = function(conn, cb) {
       if (lob === null) {
         return cb(new Error("LOB was NULL"), conn);
       }
-      cb(null, conn, lob);
+      return cb(null, conn, lob);
     });
 };
 
@@ -83,7 +83,7 @@ var  dostream = function(conn, clob, cb) {
     function(err)
     {
       console.log("clob.on 'error' event");
-      cb(err, conn);
+      return cb(err, conn);
     });
 
   // node-oracledb's lob.pieceSize is the number of bytes retrieved
@@ -112,7 +112,7 @@ var  dostream = function(conn, clob, cb) {
     function()
     {
       console.log("clob.on 'close' event");
-      cb(null, conn);
+      return cb(null, conn);
     });
 };