Handle AIX memory allocator differences

Author: cjbj

CHANGELOG.md

@@ -11,6 +11,8 @@
 - Fixed a [regression](https://github.com/oracle/node-oracledb/issues/1152) when
   binding dates with alternative JavaScript frameworks.
 
+- Fixed "NJS-024: memory allocation failed" errors seen on AIX.
+
 - Fixed a JavaScript memory leak when getting Oracle Database named type
   information, such as with `getDbObjectClass()`.
 

src/njsAqQueue.c

@@ -526,6 +526,8 @@ static bool njsAqQueue_enqManyProcessArgs(njsBaton *baton,
         return njsUtils_throwError(env, errInvalidParameterValue, 1);
     NJS_CHECK_NAPI(env, napi_get_array_length(env, args[0],
             &baton->numMsgProps))
+    if (baton->numMsgProps == 0)
+        return njsUtils_throwError(env, errInvalidParameterValue, 1);
     baton->msgProps = calloc(baton->numMsgProps, sizeof(dpiMsgProps*));
     if (!baton->msgProps)
         return njsBaton_setError(baton, errInsufficientMemory);

src/njsBaton.c

@@ -458,7 +458,7 @@ bool njsBaton_getFetchInfoFromArg(njsBaton *baton, napi_env env,
     // allocate space for the fetchInfo based on the number of keys
     NJS_CHECK_NAPI(env, napi_get_array_length(env, keys, &numElements))
     tempFetchInfo = calloc(numElements, sizeof(njsFetchInfo));
-    if (!tempFetchInfo)
+    if (!tempFetchInfo && numElements > 0)
         return njsBaton_setError(baton, errInsufficientMemory);
     *numFetchInfo = numElements;
     *fetchInfo = tempFetchInfo;
@@ -628,8 +628,11 @@ bool njsBaton_getStringArrayFromArg(njsBaton *baton, napi_env env,
     if (!array)
         return true;
 
-    // get length of array
+    // get length of array; if there are no elements in the array, nothing
+    // further needs to be done
     NJS_CHECK_NAPI(env, napi_get_array_length(env, array, &arrayLength))
+    if (arrayLength == 0)
+        return true;
 
     // allocate memory for the results
     tempStrings = calloc(arrayLength, sizeof(char*));

src/njsConnection.c

@@ -1873,14 +1873,17 @@ static bool njsConnection_initBindVars(njsBaton *baton, napi_env env,
     njsVariable *var;
     uint32_t i;
 
-    // determine the numbe of bind variables
+    // determine the number of bind variables; if none are provided, nothing
+    // further needs to be done
     if (bindNames) {
         NJS_CHECK_NAPI(env, napi_get_array_length(env, bindNames,
                 &baton->numBindVars))
     } else {
         NJS_CHECK_NAPI(env, napi_get_array_length(env, binds,
                 &baton->numBindVars))
     }
+    if (baton->numBindVars == 0)
+        return true;
 
     // allocate memory for the bind variables
     baton->bindVars = calloc(baton->numBindVars, sizeof(njsVariable));

src/njsUtils.c

@@ -274,7 +274,7 @@ bool njsUtils_copyArray(napi_env env, void *sourceArray, uint32_t numElements,
 bool njsUtils_copyString(napi_env env, char *source, size_t sourceLength,
         char **dest, size_t *destLength)
 {
-    if (source) {
+    if (source && sourceLength > 0) {
         *dest = malloc(sourceLength);
         if (!*dest)
             return njsUtils_throwError(env, errInsufficientMemory);
@@ -765,7 +765,7 @@ bool njsUtils_setPropUnsignedIntArray(napi_env env, napi_value value,
     // allocate memory for array, if applicable
     NJS_CHECK_NAPI(env, napi_get_array_length(env, value, &numElements))
     elements = calloc(numElements, sizeof(uint32_t));
-    if (!elements)
+    if (!elements && numElements > 0)
         return njsUtils_throwError(env, errInsufficientMemory);
 
     // validate values in the array

src/njsVariable.c

@@ -768,6 +768,8 @@ static bool njsVariable_processBuffer(njsVariable *var,
         case DPI_ORACLE_TYPE_NCLOB:
         case DPI_ORACLE_TYPE_BLOB:
             NJS_FREE_AND_CLEAR(buffer->lobs);
+            if (buffer->numElements == 0)
+                break;
             buffer->lobs = calloc(buffer->numElements, sizeof(njsLobBuffer));
             if (!buffer->lobs)
                 return njsBaton_setError(baton, errInsufficientMemory);