Updates the examples in the examples directory

Author: sharadraju

examples/connectionpool.js

@@ -44,12 +44,18 @@
 
 Error.stackTraceLimit = 50;
 
-// If you increase poolMax, you must increase UV_THREADPOOL_SIZE before Node.js
-// starts its thread pool.  If you set UV_THREADPOOL_SIZE too late, the value is
-// ignored and the default size of 4 is used.
-// Note on Windows you must set the UV_THREADPOOL_SIZE environment variable before
-// running your application.
-// process.env.UV_THREADPOOL_SIZE = 4;
+// Note: if you use Thick mode, and you increase poolMax, then you must also
+// increase UV_THREADPOOL_SIZE before Node.js starts its thread pool.  If you
+// set UV_THREADPOOL_SIZE too late, the value is ignored and the default size
+// of 4 is used.
+//
+// On Windows you must set the UV_THREADPOOL_SIZE environment variable
+// externally before running your application.
+//
+// Increasing UV_THREADPOOL_SIZE is not needed if you use Thin mode.
+//
+// process.env.UV_THREADPOOL_SIZE = 10; // set threadpool size to 10 for 10 connections
+
 
 const oracledb = require('oracledb');
 const dbConfig = require('./dbconfig.js');
@@ -89,7 +95,7 @@ async function init() {
       // homogeneous: true, // all connections in the pool have the same credentials
       // poolAlias: 'default', // set an alias to allow access to the pool via a name.
       // poolIncrement: 1, // only grow the pool by one connection at a time
-      // poolMax: 4, // maximum size of the pool. Increase UV_THREADPOOL_SIZE if you increase poolMax
+      // poolMax: 4, // maximum size of the pool. (Note: Increase UV_THREADPOOL_SIZE if you increase poolMax in Thick mode)
       // poolMin: 0, // start with no connections; let the pool shrink completely
       // poolPingInterval: 60, // check aliveness of connection if idle in the pool for 60 seconds
       // poolTimeout: 60, // terminate connections that are idle in the pool for 60 seconds

examples/example.js

@@ -127,7 +127,6 @@ async function run() {
     // For a complete list of options see the documentation.
     options = {
       outFormat: oracledb.OUT_FORMAT_OBJECT,   // query result format
-      // extendedMetaData: true,               // get extra metadata
       // fetchArraySize:   100                 // internal buffer allocation size for tuning
     };
 

examples/select1.js

@@ -90,7 +90,6 @@ async function run() {
       {
         maxRows: 1
         //, outFormat: oracledb.OUT_FORMAT_OBJECT  // query result format
-        //, extendedMetaData: true                 // get extra metadata
         //, fetchArraySize: 100                    // internal buffer allocation size for tuning
       });
 

examples/version.js

@@ -58,33 +58,23 @@ if (process.env.NODE_ORACLEDB_DRIVER_MODE === 'thick') {
   oracledb.initOracleClient(clientOpts);  // enable node-oracledb Thick mode
 }
 
-console.log("Run at: " + new Date());
-console.log("Node.js version: " + process.version + " (" + process.platform, process.arch + ")");
-
-console.log("Node-oracledb version:", oracledb.versionString); // version (including the suffix)
-// console.log("Node-oracledb version:", oracledb.version); // numeric version format is useful for comparisons
-// console.log("Node-oracledb version suffix:", oracledb.versionSuffix); // e.g. "-beta.1", or empty for production releases
-
-if (process.env.NODE_ORACLEDB_DRIVER_MODE === 'thick') {
-  console.log("Oracle Client library version:", oracledb.oracleClientVersionString);
-  // console.log("Oracle Client library version:", oracledb.oracleClientVersion); // numeric version format
-}
 
+// Get the database version and check the driver mode
 async function run() {
 
   let connection;
 
   try {
     connection = await oracledb.getConnection(dbConfig);
 
-    console.log("Oracle Database version:", connection.oracleServerVersionString);
-    // console.log("Oracle Database version:", connection.oracleServerVersion); // numeric version format
+    console.log("Oracle Database version       : ", connection.oracleServerVersionString);
+    // console.log("Oracle Database version       : ", connection.oracleServerVersion); // numeric version format
 
     const result = await connection.execute(
       `SELECT UNIQUE CLIENT_DRIVER
        FROM V$SESSION_CONNECT_INFO
        WHERE SID = SYS_CONTEXT('USERENV', 'SID')`);
-    console.log(result.rows[0][0]);
+    console.log("CLIENT_DRIVER                 : " + result.rows[0][0] + "'");
 
   } catch (err) {
     console.error(err);
@@ -99,4 +89,16 @@ async function run() {
   }
 }
 
+console.log("Run at                        : " + new Date());
+console.log("Node.js version               : " + process.version + " (" + process.platform, process.arch + ")");
+
+console.log("Node-oracledb version         : ", oracledb.versionString); // version (including the suffix)
+// console.log("Node-oracledb version         : ", oracledb.version); // numeric version format is useful for comparisons
+// console.log("Node-oracledb version suffix  : ", oracledb.versionSuffix); // e.g. "-beta.1", or empty for production releases
+
+if (process.env.NODE_ORACLEDB_DRIVER_MODE === 'thick') {
+  console.log("Oracle Client library version : ", oracledb.oracleClientVersionString);
+  // console.log("Oracle Client library version : ", oracledb.oracleClientVersion); // numeric version format
+}
+
 run();

examples/webapp.js

@@ -43,13 +43,18 @@
 
 Error.stackTraceLimit = 50;
 
-// If you increase poolMax, you must increase UV_THREADPOOL_SIZE before Node.js
-// starts its thread pool.  If you set UV_THREADPOOL_SIZE too late, the value is
-// ignored and the default size of 4 is used.
-// process.env.UV_THREADPOOL_SIZE = 10;   // set threadpool size to 10
+// Note: if you use Thick mode, and you increase poolMax, then you must also
+// increase UV_THREADPOOL_SIZE before Node.js starts its thread pool.  If you
+// set UV_THREADPOOL_SIZE too late, the value is ignored and the default size
+// of 4 is used.
 //
-// Note on Windows you must set the UV_THREADPOOL_SIZE environment variable before
-// running your application.
+// On Windows you must set the UV_THREADPOOL_SIZE environment variable
+// externally before running your application.
+//
+// Increasing UV_THREADPOOL_SIZE is not needed if you use Thin mode.
+//
+// process.env.UV_THREADPOOL_SIZE = 10; // set threadpool size to 10 for 10 connections
+
 
 const http = require('http');
 const oracledb = require('oracledb');
@@ -97,7 +102,7 @@ async function init() {
       // homogeneous: true, // all connections in the pool have the same credentials
       // poolAlias: 'default', // set an alias to allow access to the pool via a name.
       // poolIncrement: 1, // only grow the pool by one connection at a time
-      // poolMax: 4, // maximum size of the pool. Increase UV_THREADPOOL_SIZE if you increase poolMax
+      // poolMax: 4, // maximum size of the pool. (Note: increase UV_THREADPOOL_SIZE if you increase poolMax in Thick mode)
       // poolMin: 0, // start with no connections; let the pool shrink completely
       // poolPingInterval: 60, // check aliveness of connection if idle in the pool for 60 seconds
       // poolTimeout: 60, // terminate connections that are idle in the pool for 60 seconds