Added support for usage with extension of Array.prototype methods(Issue #1653)

Author: sharadraju

doc/src/release_notes.rst

@@ -44,6 +44,9 @@ Thin Mode Changes
 #)  Added support for Oracle Database 23c
     :ref:`Implicit Connection Pooling <implicitpool>` in DRCP and PRCP.
 
+#)  Added support for usage with extension of Array.prototype methods 
+    See `Issue #1653 <https://github.com/oracle/node-oracledb/issues/1653>`__.
+
 Thick Mode Changes
 +++++++++++++++++++
 

lib/connection.js

@@ -927,8 +927,8 @@ class Connection extends EventEmitter {
 
     // process output binds
     if (result.outBinds !== undefined) {
-      for (const key in result.outBinds) {
-        const val = this._transformOutBind(result.outBinds[key], options);
+      for (const [key, value] of Object.entries(result.outBinds)) {
+        const val = this._transformOutBind(value, options);
         result.outBinds[key] = val;
       }
     }
@@ -937,10 +937,9 @@ class Connection extends EventEmitter {
     // array size fixed, or, if a result set is not requested, that all rows
     // are fetched
     if (result.implicitResults) {
-      for (const key in result.implicitResults) {
-        const resultSetImpl = result.implicitResults[key];
+      for (const [key, impl] of Object.entries(result.implicitResults)) {
         const resultSet = new ResultSet();
-        resultSet._setup(this, resultSetImpl);
+        resultSet._setup(this, impl);
         if (options.resultSet) {
           result.implicitResults[key] = resultSet;
         } else {
@@ -996,8 +995,8 @@ class Connection extends EventEmitter {
     if (result.outBinds !== undefined) {
       for (let i = 0; i < result.outBinds.length; i++) {
         const outBind = result.outBinds[i];
-        for (const key in outBind) {
-          outBind[key] = this._transformOutBind(outBind[key], options);
+        for (const [key, value] of Object.entries(outBind)) {
+          outBind[key] = this._transformOutBind(value, options);
         }
       }
     }

lib/thin/sqlnet/ezConnectResolver.js

@@ -214,17 +214,17 @@ class EZConnectResolver {
     let naddr = 0;
     // ; groups the user into a ADDRESS_LIST
     const addressLists = hostInfo.split(";");
-    for (const addressList in addressLists) {
+    for (const addressList of addressLists) {
       let addressNodeCount = 0;
       const addressListBuilder = new Array();
-      for (const match of addressLists[addressList].matchAll(HOSTNAMES_PATTERN)) {
+      for (const match of addressList.matchAll(HOSTNAMES_PATTERN)) {
         const hostnames = (match.groups.hostnames).split(',');
         let port = match.groups.port;
         if (port == null) {
           port = '1521';    //default port
         }
-        for (const hname in hostnames) {
-          addressListBuilder.push(this.getAddrStr(hostnames[hname], port, protocol, proxyInfo));
+        for (const hname of hostnames) {
+          addressListBuilder.push(this.getAddrStr(hname, port, protocol, proxyInfo));
           addressNodeCount++;
         }
       }

lib/thin/sqlnet/navNodes.js

@@ -486,7 +486,7 @@ class NavAddress extends Address {
     if (!net.isIP(this.host)) {
       try {
         addresses = await dnsPromises.lookup(this.host, options);
-        for (const addr in addresses) {
+        for (const addr of addresses) {
           const co = new ConnOption();
           co.hostname = this.host;
           co.port = this.port;
@@ -499,7 +499,7 @@ class NavAddress extends Address {
             co.CNdata.push('(address=(protocol=' + this.prot + ')(host=' + this.host + ')(port=' + this.port + '))');
           else
             co.CNdata.push(this.toString());
-          co.host = addresses[addr].address;
+          co.host = addr.address;
           co.addr = this.addr;
           cs.getcurrentDescription().addConnectOption(co);
         }

test/fetchUrowidAsString.js

@@ -73,15 +73,15 @@ describe('116. fetchUrowidAsString.js', function() {
   });
 
   const insertData = async function(connection, tableName) {
-    for (const element in dataArray) {
-      const sql = "INSERT INTO " + tableName + "(num) VALUES(" + element + ")";
+    for (let index = 0; index < dataArray.length; index++) {
+      const sql = "INSERT INTO " + tableName + "(num) VALUES(" + index + ")";
       await connection.execute(sql);
     }
   };
 
   const updateData = async function(connection, tableName) {
-    for (const element in dataArray) {
-      const sql = "UPDATE " + tableName + " T SET content = T.ROWID where num = " + element;
+    for (let index = 0; index < dataArray.length; index++) {
+      const sql = "UPDATE " + tableName + " T SET content = T.ROWID where num = " + index;
       await connection.execute(sql);
     }
   };
@@ -442,8 +442,8 @@ describe('116. fetchUrowidAsString.js', function() {
   });
 
   async function test1(option, object) {
-    for (const element in dataArray) {
-      const sql = "select content,rowid from " + tableName + " where num = " + element;
+    for (let index = 0; index < dataArray.length; index++) {
+      const sql = "select content,rowid from " + tableName + " where num = " + index;
       const result = await connection.execute(sql, [], option);
       let resultVal_1 = result.rows[0][0];
       let resultVal_2 = result.rows[0][1];
@@ -458,8 +458,8 @@ describe('116. fetchUrowidAsString.js', function() {
   }
 
   async function test2(option, object) {
-    for (const element in dataArray) {
-      const sql = "select content,rowid from " + tableName + " where num = " + element;
+    for (let index = 0; index < dataArray.length; index++) {
+      const sql = "select content,rowid from " + tableName + " where num = " + index;
       const result = await connection.execute(sql, [], option);
       const row = await result.resultSet.getRow();
       let resultVal_1 = row[0];