Fetch and insert dates with negative years correctly in Thin mode

Author: sharadraju

doc/src/release_notes.rst

@@ -26,6 +26,9 @@ Thin Mode Changes
     increase instead of NUM_HITS in v$cpool_stats view by default. This fix
     optimizes the use of DRCP connections.
 
+#)  Fixed the issue where dates with negative years are not inserted and
+    fetched correctly in Thin mode.
+
 node-oracledb `v6.0.2 <https://github.com/oracle/node-oracledb/compare/v6.0.1...v6.0.2>`__ (27 Jun 2023)
 --------------------------------------------------------------------------------------------------------
 
@@ -71,7 +74,6 @@ Thick Mode Changes
 #)  Fixed bug with getting the value of a LOB stored in a DbObject
     `Issue #1571 <https://github.com/oracle/node-oracledb/issues/1571>`__.
 
-
 node-oracledb `v6.0.1 <https://github.com/oracle/node-oracledb/compare/v6.0.0...v6.0.1>`__ (07 Jun 2023)
 --------------------------------------------------------------------------------------------------------
 

lib/thin/protocol/buffer.js

@@ -748,7 +748,7 @@ class BaseBuffer {
     const ptr = this.reserveBytes(length);
     if (type === types.DB_TYPE_DATE || type == types.DB_TYPE_TIMESTAMP) {
       const year = date.getFullYear();
-      ptr[0] = Math.floor(year / 100) + 100;
+      ptr[0] = Math.trunc(year / 100) + 100;
       ptr[1] = year % 100 + 100;
       ptr[2] = date.getMonth() + 1;
       ptr[3] = date.getDate();
@@ -757,7 +757,7 @@ class BaseBuffer {
       ptr[6] = date.getSeconds() + 1;
     } else {
       const year = date.getUTCFullYear();
-      ptr[0] = Math.floor(year / 100) + 100;
+      ptr[0] = Math.trunc(year / 100) + 100;
       ptr[1] = year % 100 + 100;
       ptr[2] = date.getUTCMonth() + 1;
       ptr[3] = date.getUTCDate();

test/dataTypeAssist.js

@@ -213,11 +213,14 @@ assist.data = {
     new Date(10000000000),
     new Date(100000000000),
     new Date(1995, 11, 17),
+    new Date(-1995, 11, 17), // Year in BC
     new Date('1995-12-17T03:24:00'),
     new Date('2015-07-23 21:00:00'),
     new Date('2015-07-23 22:00:00'),
     new Date('2015-07-23 23:00:00'),
     new Date('2015-07-24 00:00:00'),
+    new Date('100-07-24 00:00:00'),
+    new Date(-100, 11, 17), // Year in BC
     new Date(2003, 9, 23, 11, 50, 30, 123)
   ]
 };