Skip to content

Commit bb44024

Browse files
committed
Add a toggle switch for tests requiring DBA privileges
1 parent bddde33 commit bb44024

File tree

3 files changed

+26
-3
lines changed

3 files changed

+26
-3
lines changed

test/changePassword.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,14 @@ describe('161. changePassword.js', function() {
3838
var myUser = "nodb_schema_changepw";
3939

4040
before(function(done) {
41+
42+
if (!dbConfig.DBA_PRIVILEGE) { this.skip(); }
43+
4144
async.series([
45+
function(cb) {
46+
if (!dbConfig.DBA_PRIVILEGE) { done(); }
47+
else { cb(); }
48+
},
4249
// SYSDBA connection
4350
function(cb) {
4451
var credential = {
@@ -83,6 +90,10 @@ describe('161. changePassword.js', function() {
8390

8491
after(function(done) {
8592
async.series([
93+
function(cb) {
94+
if (!dbConfig.DBA_PRIVILEGE) { done(); }
95+
else { cb(); }
96+
},
8697
function(cb) {
8798
var sql = "DROP USER " + myUser +" CASCADE";
8899
dbaConn.execute(

test/dbconfig.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ config.connectString = process.env.NODE_ORACLEDB_CONNECTIONSTRING || 'localhost/
3939
// Has external authentication set up? Negative by default.
4040
config.externalAuth = process.env.NODE_ORACLEDB_EXTERNALAUTH || false;
4141

42-
// Have you got DBA privilege? Positive by default.
43-
config.DBA_PRIVILEGE = process.env.NODE_DBA_PRIVILEGE || true;
42+
// Have you got DBA privilege? Negative by default.
43+
config.DBA_PRIVILEGE = process.env.NODE_DBA_PRIVILEGE || false;
4444

4545
config.DBA_user = process.env.NODE_ORACLEDB_DBA_USER || 'sys';
4646
config.DBA_password = process.env.NODE_ORACLEDB_DBA_PASSWORD || 'oracle';
4747

48-
module.exports = config;
48+
module.exports = config;

test/editionTest.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,14 @@ describe('160. editionTest.js', function() {
3838
var conn;
3939

4040
before(function(done) {
41+
42+
if (!dbConfig.DBA_PRIVILEGE) { this.skip(); }
43+
4144
async.series([
45+
function(cb) {
46+
if (!dbConfig.DBA_PRIVILEGE) { done(); }
47+
else { cb(); }
48+
},
4249
// SYSDBA connection
4350
function(cb) {
4451
var credential = {
@@ -224,7 +231,12 @@ describe('160. editionTest.js', function() {
224231
}); // before()
225232

226233
after(function(done) {
234+
227235
async.series([
236+
function(cb) {
237+
if (!dbConfig.DBA_PRIVILEGE) { done(); }
238+
else { cb(); }
239+
},
228240
function(cb) {
229241
var sql = "DROP EDITION nodb_e2 CASCADE";
230242
dbaConn.execute(

0 commit comments

Comments
 (0)