Throw Error for DMLS having Duplicate bind by names in the input and RETURNING INTO SQL clause (Issue #1652)

Author: sharadraju

doc/src/release_notes.rst

@@ -13,6 +13,14 @@ node-oracledb `v6.5.0 <https://github.com/oracle/node-oracledb/compare/v6.4.0...
 Thin Mode Changes
 ++++++++++++++++++
 
+#)  Error ``NJS-149: the bind variable placeholder "%s" cannot be used
+    both before and after the RETURNING clause in a DML RETURNING statement``
+    is now raised when the same bind variable placeholder name is used both
+    before and after the RETURNING clause in a
+    :ref:`DML RETURNING statement <dml-returning-bind>`. Previously, various
+    internal errors were raised.
+    See `Issue #1652 <https://github.com/oracle/node-oracledb/issues/1652>`__.
+
 #)  Added support for Oracle Database 23c
     :ref:`Implicit Connection Pooling <implicitpool>` in DRCP and PRCP.
 

lib/errors.js

@@ -144,6 +144,8 @@ const ERR_VECTOR_FORMAT_NOT_SUPPORTED = 144;
 const ERR_VECTOR_VERSION_NOT_SUPPORTED = 145;
 const ERR_OBJECT_IS_NOT_A_COLLECTION = 146;
 const ERR_CURSOR_HAS_BEEN_CLOSED = 147;
+const ERR_INVALID_POOL_BOUNDARY = 148;
+const ERR_DML_RETURNING_DUP_BINDS = 149;
 
 // Oracle Net layer errors start from 500
 const ERR_CONNECTION_CLOSED = 500;
@@ -420,6 +422,10 @@ messages.set(ERR_OBJECT_IS_NOT_A_COLLECTION,            // NJS-146
   'object %s is not a collection');
 messages.set(ERR_CURSOR_HAS_BEEN_CLOSED,                // NJS-147
   'cursor has been closed by the database');
+messages.set(ERR_INVALID_POOL_BOUNDARY,                 // NJS-148
+  'invalid value of POOL_BOUNDARY in connect string');
+messages.set(ERR_DML_RETURNING_DUP_BINDS,               // NJS-149
+  'the bind variable placeholder "%s" cannot be used both before and after the RETURNING clause in a DML RETURNING statement');
 
 // Oracle Net layer errors
 
@@ -812,6 +818,8 @@ module.exports = {
   ERR_VECTOR_VERSION_NOT_SUPPORTED,
   ERR_OBJECT_IS_NOT_A_COLLECTION,
   ERR_CURSOR_HAS_BEEN_CLOSED,
+  ERR_INVALID_POOL_BOUNDARY,
+  ERR_DML_RETURNING_DUP_BINDS,
   ERR_CONNECTION_CLOSED_CODE: `${ERR_PREFIX}-${ERR_CONNECTION_CLOSED}`,
   WRN_COMPILATION_CREATE,
   assert,

lib/thin/statement.js

@@ -28,6 +28,7 @@
 
 const { Buffer } = require('buffer');
 const constants = require('../constants');
+const errors = require('../errors');
 
 /**
  * It is used to cache the metadata about bind information
@@ -496,6 +497,12 @@ class Statement {
       const info = new BindInfo(name, this.isReturning);
       this.bindInfoList.push(info);
       if (this.bindInfoDict.has(info.bindName)) {
+        if (this.isReturning) {
+          const origInfo = this.bindInfoDict.get(info.bindName)[0];
+          if (!origInfo.isReturnBind) {
+            errors.throwErr(errors.ERR_DML_RETURNING_DUP_BINDS, name);
+          }
+        }
         this.bindInfoDict.get(info.bindName).push(info);
       } else {
         this.bindInfoDict.set(info.bindName, [info]);

test/dmlReturning.js

@@ -327,6 +327,40 @@ describe('6. dmlReturning.js', function() {
       assert.deepStrictEqual(info.bindNames, ["I", "RID", "MÉIL"]);
     });
 
+    it('6.1.16 Execute DML with Duplicated bind names for input and returning into clause', async function() {
+      if (!oracledb.thin) {
+        this.skip();
+      }
+
+      // Insert DML with returning into clause
+      let sql = "INSERT INTO nodb_dmlreturn (id, name) VALUES (:int_val, :str_val) RETURNING id, name into :rid, :str_val";
+      let inpstr = "A different test string";
+      let binds = {
+        int_val: 6,
+        rid: { type: oracledb.NUMBER, dir: oracledb.BIND_OUT },
+        str_val: { type: oracledb.STRING, val: inpstr, dir: oracledb.BIND_INOUT, maxSize: inpstr.length }
+      };
+      const options = {
+        autoCommit: true
+      };
+      await assert.rejects(
+        async () => await connection.execute(sql, binds, options),
+        /NJS-149:/
+      );
+
+      // update DML with returning into clause
+      sql = "update nodb_dmlreturn set name = name || :name_val  where id = :id_val returning name into :name_val";
+      inpstr = "A different test string";
+      binds = {
+        id_val: 6,
+        name_val: { type: oracledb.STRING, val: inpstr, dir: oracledb.BIND_INOUT, maxSize: 500 }
+      };
+      await assert.rejects(
+        async () => await connection.execute(sql, binds, options),
+        /NJS-149:/
+      );
+    });
+
   }); // 6.1
 
   describe('6.2 DATE and TIMESTAMP data', function() {

test/list.txt

@@ -210,6 +210,7 @@ Overview of node-oracledb functional tests
         6.1.13 INSERT statement with NaN
         6.1.14 INSERT statement with an invalid bind name (reserved namespace keyword)
         6.1.15 INSERT statement parse non ascii returning bind
+        6.1.16 Execute DML with Duplicated bind names for input and returning into clause
     6.2 DATE and TIMESTAMP data
         6.2.1 INSERT statement, single row matched, Object binding, no bind in data
         6.2.2 INSERT statement with JavaScript date bind in