File tree Expand file tree Collapse file tree 3 files changed +10
-4
lines changed Expand file tree Collapse file tree 3 files changed +10
-4
lines changed Original file line number Diff line number Diff line change @@ -8,6 +8,12 @@ node-oracledb Release Notes
8
8
node-oracledb `v6.0.3 <https://github.com/oracle/node-oracledb/compare/v6.0.2...v6.0.3 >`__ (TBD)
9
9
------------------------------------------------------------------------------------------------
10
10
11
+ Common Changes
12
+ ++++++++++++++
13
+
14
+ #) Fixed bug to consistently use the DRCP :attr: `oracledb.connectionClass ` in effect when the
15
+ pool was created.
16
+
11
17
Thin Mode Changes
12
18
+++++++++++++++++
13
19
Original file line number Diff line number Diff line change @@ -47,6 +47,7 @@ class Pool extends EventEmitter {
47
47
this . _timeOfReset = this . _createdDate = Date . now ( ) ;
48
48
this . _sessionCallback = undefined ;
49
49
this . _connRequestQueue = [ ] ;
50
+ this . _connectionClass = settings . connectionClass ;
50
51
}
51
52
52
53
//---------------------------------------------------------------------------
@@ -376,7 +377,9 @@ class Pool extends EventEmitter {
376
377
errors . assertParamValue ( nodbUtil . isObject ( a1 ) , 1 ) ;
377
378
options = this . _verifyGetConnectionOptions ( a1 ) ;
378
379
}
379
- settings . addToOptions ( options , "connectionClass" ) ;
380
+
381
+ // get connection class value from pool
382
+ options . connectionClass = this . _connectionClass ;
380
383
381
384
// if pool is draining/closed, throw an appropriate error
382
385
this . _checkPoolOpen ( true ) ;
Original file line number Diff line number Diff line change @@ -212,9 +212,6 @@ class ThinPoolImpl extends PoolImpl {
212
212
// create new connection and return it
213
213
//---------------------------------------------------------------------------
214
214
async getConnection ( ) {
215
- if ( settings . connectionClass !== '' ) {
216
- this . _userConfig . connectionClass = settings . connectionClass ;
217
- }
218
215
return await this . acquire ( ) ;
219
216
}
220
217
You can’t perform that action at this time.
0 commit comments