Skip to content

Commit c00ab72

Browse files
cjbjcjbj
committed
Update Number(), String() test assertions
1 parent d3bc2cd commit c00ab72

File tree

9 files changed

+39
-39
lines changed

9 files changed

+39
-39
lines changed

‎test/binding.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ describe('4. binding.js', function() {
312312
function(err, result) {
313313
should.not.exist(err);
314314
// console.log(result);
315-
result.outBinds.n.should.be.a.String;
315+
result.outBinds.n.should.be.a.String();
316316
result.outBinds.n.should.eql('1001');
317317
done();
318318
}

‎test/clobPlsqlString.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ describe('60. clobPlsqlString.js', function() {
108108
},
109109
function(err, result) {
110110
should.not.exist(err);
111-
(result.outBinds.cbv).should.be.a.String;
111+
(result.outBinds.cbv).should.be.a.String();
112112
(result.outBinds.cbv).should.eql('abcdefghijklmnopqrstuvwxyz');
113113
done();
114114
}

‎test/dataTypeTimestamp1.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ describe('33. dataTypeTimestamp1.js', function() {
148148
options,
149149
function(err, result) {
150150
should.not.exist(err);
151-
(result.outBinds.bv).should.be.a.String;
151+
(result.outBinds.bv).should.be.a.String();
152152
done();
153153
}
154154
);

‎test/examples.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ describe('3. examples.js', function(){
5555

5656
describe('3.2 version.js', function(){
5757
it('3.2.1 shows the oracledb version attribute', function(){
58-
(oracledb.version).should.be.a.Number;
58+
(oracledb.version).should.be.a.Number();
5959
(oracledb.version).should.be.greaterThan(0);
6060
// console.log("Driver version number is " + oracledb.version);
6161

‎test/fetchAs.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe('56. fetchAs.js', function() {
8282
function(err, result) {
8383
should.not.exist(err);
8484
// console.log(result.rows[0]);
85-
result.rows[0].TS_DATE.should.be.a.String;
85+
result.rows[0].TS_DATE.should.be.a.String();
8686
done();
8787
}
8888
);
@@ -103,8 +103,8 @@ describe('56. fetchAs.js', function() {
103103
function(err, result) {
104104
should.not.exist(err);
105105
// console.log(result.rows[0]);
106-
result.rows[0].TS_DATE.should.be.a.String;
107-
result.rows[0].TS_NUM.should.be.a.String;
106+
result.rows[0].TS_DATE.should.be.a.String();
107+
result.rows[0].TS_NUM.should.be.a.String();
108108
Number(result.rows[0].TS_NUM).should.equal(1234567);
109109
done();
110110
}
@@ -128,8 +128,8 @@ describe('56. fetchAs.js', function() {
128128
function(err, result) {
129129
should.not.exist(err);
130130
// console.log(result.rows[0]);
131-
result.rows[0].TS_DATE.should.be.a.String;
132-
result.rows[0].TS_NUM.should.be.a.String;
131+
result.rows[0].TS_DATE.should.be.a.String();
132+
result.rows[0].TS_NUM.should.be.a.String();
133133
Number(result.rows[0].TS_NUM).should.equal(1234567);
134134
done();
135135
}
@@ -154,7 +154,7 @@ describe('56. fetchAs.js', function() {
154154
should.not.exist(err);
155155
// console.log(result.rows[0]);
156156
result.rows[0].TS_DATE.should.be.an.Object;
157-
result.rows[0].TS_NUM.should.be.a.String;
157+
result.rows[0].TS_NUM.should.be.a.String();
158158
Number(result.rows[0].TS_NUM).should.equal(1234567);
159159
done();
160160
}
@@ -175,7 +175,7 @@ describe('56. fetchAs.js', function() {
175175
function(err, result) {
176176
should.not.exist(err);
177177
// console.log(result.rows[0].TS_DATA);
178-
result.rows[0].ROWID.should.be.a.String;
178+
result.rows[0].ROWID.should.be.a.String();
179179
done();
180180
}
181181
);
@@ -199,7 +199,7 @@ describe('56. fetchAs.js', function() {
199199
result.resultSet.getRow( function(err, row) {
200200
should.not.exist(err);
201201
// console.log(row);
202-
row.ROWID.should.be.a.String;
202+
row.ROWID.should.be.a.String();
203203
result.resultSet.close( function(err) {
204204
should.not.exist(err);
205205
done();
@@ -247,7 +247,7 @@ describe('56. fetchAs.js', function() {
247247
},
248248
function(err, result) {
249249
should.not.exist(err);
250-
result.rows[0].TS_NUM.should.be.a.String;
250+
result.rows[0].TS_NUM.should.be.a.String();
251251
(result.rows[0].TS_NUM).should.eql(numResults[numStrs.indexOf(element)]);
252252
callback();
253253
}
@@ -269,7 +269,7 @@ describe('56. fetchAs.js', function() {
269269
function(err, result) {
270270
should.not.exist(err);
271271
// console.log(result.rows[0].TS_NUM);
272-
result.rows[0].TS_NUM.should.be.a.String;
272+
result.rows[0].TS_NUM.should.be.a.String();
273273
(result.rows[0].TS_NUM).should.eql(numResults[numStrs.indexOf(element)]);
274274
callback();
275275
}

‎test/lobProperties.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,8 @@ describe('62. lobProperties.js', function() {
196196
var t1 = clob.chunkSize,
197197
t2 = blob.chunkSize;
198198

199-
t1.should.be.a.Number;
200-
t2.should.be.a.Number;
199+
t1.should.be.a.Number();
200+
t2.should.be.a.Number();
201201
t1.should.eql(t2);
202202
defaultChunkSize = clob.chunkSize;
203203

@@ -233,8 +233,8 @@ describe('62. lobProperties.js', function() {
233233
var t1 = clob.length,
234234
t2 = blob.length;
235235

236-
t1.should.be.a.Number;
237-
t2.should.be.a.Number;
236+
t1.should.be.a.Number();
237+
t2.should.be.a.Number();
238238
t1.should.not.eql(t2);
239239

240240
try {

‎test/pool.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ describe('2. pool.js', function() {
5252
var defaultTimeout = 60;
5353
var defaultStmtCacheSize = 30;
5454

55-
pool.poolMin.should.be.exactly(defaultMin).and.be.a.Number;
56-
pool.poolMax.should.be.exactly(defaultMax).and.be.a.Number;
57-
pool.poolIncrement.should.be.exactly(defaultIncrement).and.be.a.Number;
58-
pool.poolTimeout.should.be.exactly(defaultTimeout).and.be.a.Number;
59-
pool.stmtCacheSize.should.be.exactly(defaultStmtCacheSize).and.be.a.Number;
55+
pool.poolMin.should.be.exactly(defaultMin).and.be.a.Number();
56+
pool.poolMax.should.be.exactly(defaultMax).and.be.a.Number();
57+
pool.poolIncrement.should.be.exactly(defaultIncrement).and.be.a.Number();
58+
pool.poolTimeout.should.be.exactly(defaultTimeout).and.be.a.Number();
59+
pool.stmtCacheSize.should.be.exactly(defaultStmtCacheSize).and.be.a.Number();
6060

6161
pool.connectionsOpen.should.equal(0);
6262
pool.connectionsInUse.should.equal(0);

‎test/poolTimeout.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,11 @@ describe('11. poolTimeout.js', function(){
7676
it('11.1 pool terminates idle connections after specify time', function(done){
7777
pool.should.be.ok();
7878
if(!dbConfig.externalAuth){
79-
pool.connectionsOpen.should.be.exactly(1).and.be.a.Number;
79+
pool.connectionsOpen.should.be.exactly(1).and.be.a.Number();
8080
} else {
8181
pool.connectionsOpen.should.be.exactly(0);
8282
}
83-
pool.connectionsInUse.should.be.exactly(0).and.be.a.Number;
83+
pool.connectionsInUse.should.be.exactly(0).and.be.a.Number();
8484

8585
var conn1 = null;
8686
var conn2 = null;

‎test/properties.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ describe('58. properties.js', function() {
143143
})
144144

145145
it('58.1.8 version (read-only)', function() {
146-
(oracledb.version).should.be.a.Number;
146+
(oracledb.version).should.be.a.Number();
147147

148148
try {
149149
oracledb.version = 5;
@@ -156,7 +156,7 @@ describe('58. properties.js', function() {
156156

157157
it('58.1.9 connClass', function() {
158158
oracledb.connClass = "cc";
159-
(oracledb.connClass).should.be.a.String;
159+
(oracledb.connClass).should.be.a.String();
160160
})
161161

162162
it('58.1.10 externalAuth', function() {
@@ -193,7 +193,7 @@ describe('58. properties.js', function() {
193193

194194
it('58.1.14 oracleClientVersion (read-only)', function () {
195195
var t = oracledb.oracleClientVersion ;
196-
t.should.be.a.Number;
196+
t.should.be.a.Number();
197197

198198
try {
199199
oracledb.oracleClientVersion = t + 1;
@@ -252,7 +252,7 @@ describe('58. properties.js', function() {
252252

253253
it('58.2.1 poolMin', function() {
254254
var t = pool.poolMin;
255-
t.should.be.a.Number;
255+
t.should.be.a.Number();
256256

257257
try {
258258
pool.poolMin = t + 1;
@@ -264,7 +264,7 @@ describe('58. properties.js', function() {
264264

265265
it('58.2.2 poolMax', function() {
266266
var t = pool.poolMax;
267-
t.should.be.a.Number;
267+
t.should.be.a.Number();
268268

269269
try {
270270
pool.poolMax = t + 1;
@@ -276,7 +276,7 @@ describe('58. properties.js', function() {
276276

277277
it('58.2.3 poolIncrement', function() {
278278
var t = pool.poolIncrement;
279-
t.should.be.a.Number;
279+
t.should.be.a.Number();
280280

281281
try {
282282
pool.poolIncrement = t + 1;
@@ -288,7 +288,7 @@ describe('58. properties.js', function() {
288288

289289
it('58.2.4 poolTimeout', function() {
290290
var t = pool.poolTimeout;
291-
t.should.be.a.Number;
291+
t.should.be.a.Number();
292292

293293
try {
294294
pool.poolTimeout = t + 1;
@@ -300,7 +300,7 @@ describe('58. properties.js', function() {
300300

301301
it('58.2.5 stmtCacheSize', function() {
302302
var t = pool.stmtCacheSize;
303-
t.should.be.a.Number;
303+
t.should.be.a.Number();
304304

305305
try {
306306
pool.stmtCacheSize = t + 1;
@@ -312,7 +312,7 @@ describe('58. properties.js', function() {
312312

313313
it('58.2.6 connectionsInUse', function() {
314314
var t = pool.connectionsInUse;
315-
t.should.be.a.Number;
315+
t.should.be.a.Number();
316316

317317
try {
318318
pool.connectionsInUse = t + 1;
@@ -324,7 +324,7 @@ describe('58. properties.js', function() {
324324

325325
it('58.2.7 connectionsOpen', function() {
326326
var t = pool.connectionsOpen;
327-
t.should.be.a.Number;
327+
t.should.be.a.Number();
328328

329329
try {
330330
pool.connectionsOpen = t + 1;
@@ -348,7 +348,7 @@ describe('58. properties.js', function() {
348348

349349
it.skip('58.2.9 queueTimeout', function() {
350350
var t = pool.queueTimeout;
351-
t.should.be.a.Number;
351+
t.should.be.a.Number();
352352

353353
try {
354354
pool.queueTimeout = t + 1000;
@@ -385,13 +385,13 @@ describe('58. properties.js', function() {
385385
should.equal(connection.module, null);
386386
should.equal(connection.clientId, null);
387387

388-
(connection.stmtCacheSize).should.be.a.Number;
388+
(connection.stmtCacheSize).should.be.a.Number();
389389
(connection.stmtCacheSize).should.be.greaterThan(0);
390390
})
391391

392392
it('58.3.2 stmtCacheSize (read-only)', function() {
393393
var t = connection.stmtCacheSize;
394-
t.should.be.a.Number;
394+
t.should.be.a.Number();
395395

396396
try {
397397
connection.stmtCacheSize = t + 1;
@@ -459,7 +459,7 @@ describe('58. properties.js', function() {
459459

460460
it('58.3.6 oracleServerVersion (read-only)', function () {
461461
var t = connection.oracleServerVersion;
462-
t.should.be.a.Number;
462+
t.should.be.a.Number();
463463

464464
try {
465465
connection.oracleServerVersion = t + 1;

0 commit comments

Comments
 (0)