Test owned property fix

Author: cjbj

test/aq2.js

@@ -288,4 +288,4 @@ describe('218. aq2.js', function() {
       should.not.exist(err);
     }
   }); // 218.7
-});
+});

test/examineOwnedProperties.js

@@ -0,0 +1,124 @@
+/* Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. */
+
+/******************************************************************************
+ *
+ * You may not use the identified files except in compliance with the Apache
+ * License, Version 2.0 (the "License.")
+ *
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * NAME
+ *   220. examineOwnedProperties.js
+ *
+ * DESCRIPTION
+ *   Add this test from GitHub issue 1129 to prevent regression.
+ *   https://github.com/oracle/node-oracledb/issues/1129
+ *
+ *****************************************************************************/
+'use strict';
+
+const oracledb  = require('oracledb');
+const should    = require('should');
+const dbconfig  = require('./dbconfig.js');
+const testsUtil = require('./testsUtil.js');
+
+describe('220. examineOwnedProperties.js', () => {
+
+  let conn;
+  const TABLE = "nodb_tab_rating";
+
+  before(async () => {
+    try {
+      conn = await oracledb.getConnection(dbconfig);
+
+      let sql = `
+        CREATE TABLE ${TABLE} (
+            "RATE_TIME" VARCHAR2(32),
+            "RATE_USER" VARCHAR2(128),
+            "ITEM_PRICE" NUMBER,
+            "RATING" VARCHAR2(4000)
+        )
+      `;
+      let plsql = testsUtil.sqlCreateTable(TABLE, sql);
+      await conn.execute(plsql);
+    } catch (err) {
+      should.not.exist(err);
+    }
+  }); // before()
+
+  after(async () => {
+    try {
+      let sql = `DROP TABLE ${TABLE} PURGE`;
+      await conn.execute(sql);
+      conn.close();
+    } catch (err) {
+      should.not.exist(err);
+    }
+  }); // after()
+
+  it('220.1 Only examine "owned" properties on objects', async () => {
+    try {
+      const sql = `
+        MERGE INTO ${TABLE} R USING (
+          SELECT
+            :item_price as itemPrice,
+            :rate_time as rateTime,
+            :rate_user as rateUser,
+            :rating as rating
+          FROM DUAL ) T ON (
+            R.RATE_TIME     = T.rateTime
+            AND R.RATE_USER = T.rateUser
+        ) WHEN MATCHED THEN UPDATE SET
+            R.ITEM_PRICE = T.itemPrice
+            , R.RATING   = T.rating
+        WHEN NOT MATCHED THEN INSERT (
+            RATE_TIME
+            , RATE_USER
+            , ITEM_PRICE
+            , RATING
+        ) VALUES (
+          T.rateTime
+          , T.rateUser
+          , T.itemPrice
+          , T.rating
+        )
+      `;
+      const data = [
+        { "rate_user": "Bob",
+          "rate_time": "2019-07-26 19:42:36",
+          "item_price":338,
+          "rating":"I like it"
+        },
+        { "rate_user": "Alice",
+          "rate_time": "2019-07-26 19:42:36",
+          "item_price":338,
+          "rating":"I like it too"
+        }
+      ];
+      const options = {
+        autoCommit: true,
+        bindDefs: {
+          item_price : { type: oracledb.NUMBER },
+          rate_time  : { type: oracledb.STRING, maxSize: 32 },
+          rate_user  : { type: oracledb.STRING, maxSize: 128 },
+          rating     : { type: oracledb.STRING, maxSize: 4000 },
+        }
+      };
+
+      Object.prototype.noop = () => {};
+
+      await conn.executeMany(sql, data, options);
+
+    } catch (err) {
+      should.not.exist(err);
+    }
+  }); // 220.1
+});

test/list.txt

@@ -4612,4 +4612,7 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
     219.4 Negative - Set "maxMessages" argument to be -5
     219.5 Negative - Set "maxMessages" argument to be 0
     219.6 Enqueue a Buffer
-    219.7 enqMany() mixes enqueuing string and buffer
+    219.7 enqMany() mixes enqueuing string and buffer
+
+220. examineOwnedProperties.js
+    220.1 Only examine "owned" properties on objects

test/opts/mocha.opts

@@ -220,9 +220,7 @@ test/fetchBinaryTypesAsString.js
 test/currentSchema.js
 
 test/implicitResults.js
-
 test/getDataOfLob.js
-
 test/dbObjectsNestTbl.js
 
 test/dbObject1.js
@@ -244,4 +242,7 @@ test/dbObject16.js
 test/dbObject17.js
 
 test/aq1.js
-test/aq2.js
+test/aq2.js
+test/aq3.js
+
+test/examineOwnedProperties.js