Skip to content

Commit c39587a

Browse files
committed
Bump version to 4.0.0 production
1 parent d0122e3 commit c39587a

File tree

5 files changed

+7
-13
lines changed

5 files changed

+7
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
# Change Log
22

3-
## node-oracledb v4.0.0-dev (DD Mon YYYY)
4-
5-
**This release is under development**
3+
## node-oracledb v4.0.0 (25 Jul 2019)
64

75
- Refactored the node-oracledb implementation to use
86
[N-API](https://nodejs.org/api/n-api.html) in place of

doc/api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# node-oracledb 4.0.0-dev Documentation for the Oracle Database Node.js Add-on
1+
# node-oracledb 4.0 Documentation for the Oracle Database Node.js Add-on
22

33
*Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved.*
44

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "oracledb",
3-
"version": "4.0.0-dev",
3+
"version": "4.0.0",
44
"description": "A Node.js module for Oracle Database access",
55
"license": "Apache-2.0",
66
"homepage": "http://oracle.github.io/node-oracledb/",

src/njsModule.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@
3838

3939
// Keep the version in sync with package.json.
4040
// The suffix should be something like "-dev" or "-beta.1".
41-
// For production, leave NJS_NODE_ORACLEDB_SUFFIX undefined (not "")
41+
// For production, use: #define NJS_NODE_ORACLEDB_SUFFIX ""
4242
#define NJS_NODE_ORACLEDB_MAJOR 4
4343
#define NJS_NODE_ORACLEDB_MINOR 0
4444
#define NJS_NODE_ORACLEDB_PATCH 0
45-
#define NJS_NODE_ORACLEDB_SUFFIX "-dev"
45+
#define NJS_NODE_ORACLEDB_SUFFIX ""
4646

4747
// define stringified version and driver name
4848
#define NJS_STR_HELPER(x) #x

src/njsOracleDb.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1005,7 +1005,7 @@ static napi_value njsOracleDb_getVersionString(napi_env env,
10051005
napi_callback_info info)
10061006
{
10071007
return njsUtils_convertToString(env, NJS_VERSION_STRING,
1008-
strlen(NJS_VERSION_STRING));
1008+
sizeof(NJS_VERSION_STRING)-1);
10091009
}
10101010

10111011

@@ -1016,12 +1016,8 @@ static napi_value njsOracleDb_getVersionString(napi_env env,
10161016
static napi_value njsOracleDb_getVersionSuffix(napi_env env,
10171017
napi_callback_info info)
10181018
{
1019-
#ifdef NJS_NODE_ORACLEDB_SUFFIX
10201019
return njsUtils_convertToString(env, NJS_NODE_ORACLEDB_SUFFIX,
1021-
strlen(NJS_NODE_ORACLEDB_SUFFIX));
1022-
#else
1023-
return NULL;
1024-
#endif
1020+
sizeof(NJS_NODE_ORACLEDB_SUFFIX)-1);
10251021
}
10261022

10271023

0 commit comments

Comments
 (0)