Skip to content

Commit d3fae22

Browse files
committed
Update ODPI-C to eliminate DPI-1054 errors
Automatically close result sets and LOBs when the connection is closed.
1 parent 9fefee4 commit d3fae22

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

binding.gyp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"odpi/src/dpiError.c",
2121
"odpi/src/dpiGen.c",
2222
"odpi/src/dpiGlobal.c",
23+
"odpi/src/dpiHandleList.c",
2324
"odpi/src/dpiHandlePool.c",
2425
"odpi/src/dpiLob.c",
2526
"odpi/src/dpiMsgProps.c",

test/resultSet2.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -290,14 +290,14 @@ describe('55. resultSet2.js', function() {
290290
return fetchRowFromRS(rs, cb);
291291
} else {
292292
testConn.release(function(err) {
293-
should.exist(err);
294-
should.strictEqual(
295-
err.message,
296-
"DPI-1054: connection cannot be closed when open statements or LOBs exist"
297-
);
293+
should.not.exist(err);
298294
rs.close(function(err) {
299-
should.not.exist(err);
300-
testConn.release(cb);
295+
should.exist(err);
296+
should.strictEqual(
297+
err.message,
298+
"NJS-018: invalid ResultSet"
299+
);
300+
cb();
301301
});
302302
});
303303
}

0 commit comments

Comments
 (0)