Added pool.reconfigure()

Author: cjbj

CHANGELOG.md

@@ -6,8 +6,26 @@
 
 - Connection pool changes:
 
-    - Fixed connection pool statistics "min time in queue" and "max time in
-      queue" calculations.
+    - Pool attributes can be changed during application runtime with
+      [`pool.reconfigure()`](https://oracle.github.io/node-oracledb/doc/api.html#poolreconfigure).
+      This lets properties such as the pool size be changed dynamically instead
+      of having to restart the application or create a new pool.
+
+    - Formalized pool statistics with the addition of a pool creation attribute
+      [`enableStatistics`](https://oracle.github.io/node-oracledb/doc/api.html#createpoolpoolattrsstats),
+      and with the functions
+      [`pool.getStatistics()`](https://oracle.github.io/node-oracledb/doc/api.html#poolgetstatistics)
+      and
+      [`pool.logStatistics()`](https://oracle.github.io/node-oracledb/doc/api.html#poollogstatistics).
+      Pool statistics can be be enabled, disabled, or reset with
+      `pool.reconfigure()`.  The older `_enableStats` attribute and
+      `_logStats()` function are aliases for the new functionality but will be
+      removed in a future version of node-oracledb.
+
+    - Added `currentQueueLength` and `poolMaxPerShard` to the pool statistics.
+
+    - Fixed connection pool statistics "minimum time in queue" and "maximum
+      time in queue" calculations.
 
     - Fixed the statement cache size set for the initial `poolMin` connections
       created by `oracledb.createPool()`.

doc/api.md

@@ -79,7 +79,7 @@ async function init() {
       // sessionCallback: myFunction, // function invoked for brand new connections or by a connection tag mismatch
       // sodaMetaDataCache: false, // Set true to improve SODA collection access performance
       // stmtCacheSize: 30, // number of statements that are cached in the statement cache of each connection
-      // _enableStats: false // record pool usage statistics that can be output with oracledb.getPool()._logStats()
+      // enableStatistics: false // record pool usage for oracledb.getPool().getStatistics() and logStatistics()
     });
     console.log('Connection pool started');
 
@@ -103,7 +103,7 @@ async function dostuff() {
     const options = { outFormat: oracledb.OUT_FORMAT_OBJECT };
     const result = await connection.execute(sql, binds, options);
     console.log(result);
-    // oracledb.getPool()._logStats(); // show pool statistics.  _enableStats must be true
+    // oracledb.getPool().logStatistics(); // show pool statistics.  pool.enableStatistics must be true
   } catch (err) {
     console.error(err);
   } finally {

examples/connectionpool.js

@@ -89,7 +89,7 @@ async function init() {
       // sessionCallback: initSession, // function invoked for brand new connections or by a connection tag mismatch
       // sodaMetaDataCache: false, // Set true to improve SODA collection access performance
       // stmtCacheSize: 30, // number of statements that are cached in the statement cache of each connection
-      // _enableStats: false // record pool usage statistics that can be output with oracledb.getPool()._logStats()
+      // enableStatistics: false // record pool usage for oracledb.getPool().getStatistics() and logStatistics()
     });
 
     // create the demo table