Skip to content

Commit dd00f2b

Browse files
committed
Updated the ClientInfo terminal parameter to remove the hardcoded value (See Issue #1662)
1 parent c83cc1e commit dd00f2b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

doc/src/release_notes.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ Common Changes
3939

4040
Thin Mode Changes
4141
++++++++++++++++++
42+
#) Updated the ClientInfo terminal parameter to remove the hardcoded value.
43+
See `Issue #1662 <https://github.com/oracle/node-oracledb/issues/1662>`__.
44+
4245
#) Fixed issue with connecting to Oracle Database, when the full path of
4346
the Node.js executable contains certain non-standard characters like '(' and ')'.
4447
See `Issue #1644 <https://github.com/oracle/node-oracledb/issues/1664>`__.

lib/thin/protocol/messages/auth.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ class AuthMessage extends Message {
181181
if (this.userByteLen > 0) {
182182
buf.writeBytesWithLength(Buffer.from(this.username));
183183
}
184-
buf.writeKeyValue("AUTH_TERMINAL", "unknown");
184+
buf.writeKeyValue("AUTH_TERMINAL", cInfo.terminal);
185185
buf.writeKeyValue("AUTH_PROGRAM_NM", cInfo.program);
186186
buf.writeKeyValue("AUTH_MACHINE", cInfo.hostName);
187187
buf.writeKeyValue("AUTH_PID", cInfo.pid);

0 commit comments

Comments
 (0)