Skip to content

Commit e6c436c

Browse files
committed
Fix results.metaData for queries with {resultSet:true}
1 parent 6ff0b7b commit e6c436c

File tree

5 files changed

+428
-382
lines changed

5 files changed

+428
-382
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Change Log
22

3+
## node-oracledb v1.9.2 (DD Mon YYYY)
4+
5+
- Fix `results.metaData` for queries with `{resultSet: true}`
6+
37
## node-oracledb v1.9.1 (18 May 2016)
48

59
- Upgraded to NAN 2.3 for Node 6 support.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "oracledb",
3-
"version": "1.9.1",
3+
"version": "1.9.2",
44
"description": "Oracle Database driver by Oracle Corp.",
55
"license": "Apache-2.0",
66
"homepage": "http://www.oracle.com/technetwork/database/database-technologies/scripting-languages/node_js/",

src/njs/src/njsConnection.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1509,17 +1509,17 @@ void Connection::Async_Execute (uv_work_t *req)
15091509

15101510
executeBaton->dpistmt->execute(0, executeBaton->autoCommit);
15111511

1512-
if ( executeBaton->getRS )
1513-
{
1514-
goto exitAsyncExecute;
1515-
}
1516-
15171512
const dpi::MetaData* meta = executeBaton->dpistmt->getMetaData();
15181513
executeBaton->numCols = executeBaton->dpistmt->numCols();
15191514
executeBaton->columnNames = new std::string[executeBaton->numCols];
15201515
Connection::CopyMetaData( executeBaton->columnNames, meta,
15211516
executeBaton->numCols );
15221517

1518+
if ( executeBaton->getRS )
1519+
{
1520+
goto exitAsyncExecute;
1521+
}
1522+
15231523
Connection::DoDefines(executeBaton, meta, executeBaton->numCols);
15241524
/* If any errors while creating define structures, bail out */
15251525
if ( !executeBaton->error.empty() )

src/njs/src/njsOracle.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ using namespace v8;
7070
/* Keep the version in sync with package.json */
7171
#define NJS_NODE_ORACLEDB_MAJOR 1
7272
#define NJS_NODE_ORACLEDB_MINOR 9
73-
#define NJS_NODE_ORACLEDB_PATCH 1
73+
#define NJS_NODE_ORACLEDB_PATCH 2
7474

7575
/* Used for Oracledb.version */
7676
#define NJS_NODE_ORACLEDB_VERSION ( (NJS_NODE_ORACLEDB_MAJOR * 10000) + \

0 commit comments

Comments
 (0)