Add regression tests

Author: cjbj

test/v8Getter.js renamed to test/jsObjectGetter1.js

@@ -19,11 +19,11 @@
  * See LICENSE.md for relevant licenses.
  *
  * NAME
- *   140. v8Getter.js
+ *   140. jsObjectGetter1.js
  *
  * DESCRIPTION
- *   Test v8 object getter functions. These cases overwrite the getter()
- *   functions.
+ *   These tests overwrite the getter methods of node-oracledb javaScript
+ *   objects.
  *
  *****************************************************************************/
 'use strict';
@@ -33,7 +33,7 @@ var should   = require('should');
 var async    = require('async');
 var dbConfig = require('./dbconfig.js');
 
-describe('140. v8Getter.js', function() {
+describe('140. jsObjectGetter1.js', function() {
 
   var connection = null;
   var tableName = "nodb_tab_v8getter";

test/jsObjectGetter2.js

@@ -0,0 +1,120 @@
+/* Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. */
+
+/******************************************************************************
+ *
+ * You may not use the identified files except in compliance with the Apache
+ * License, Version 2.0 (the "License.")
+ *
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * The node-oracledb test suite uses 'mocha', 'should' and 'async'.
+ * See LICENSE.md for relevant licenses.
+ *
+ * NAME
+ *   171. jsObjectGetter2.js
+ *
+ * DESCRIPTION
+ *   It checks the safe use of the Maybe value returned by 
+ *   JS Object Set methods.
+ *
+ *****************************************************************************/
+'use strict';
+
+const oracledb = require('oracledb');
+const should   = require('should');
+const dbconfig = require('./dbconfig.js');
+
+describe('171. jsObjectGetter2.js', () => {
+
+  it.skip('171.1 oracledb.fetchAsBuffer', () => {
+    let foo = [ oracledb.BLOB ];
+    Object.defineProperty(foo, '0', {
+      get: function() {
+        throw 'Nope';
+      }
+    });
+
+    try {
+      oracledb.fetchAsBuffer = foo;
+    } catch(err) {
+      console.log(err);
+    } finally {
+      oracledb.fetchAsBuffer = []; // restore
+    }
+  }); // 171.1
+
+  it.skip('171.2 oracledb.fetchAsString', () => {
+    let foo = [ oracledb.CLOB ];
+    Object.defineProperty(foo, '0', {
+      get: function() {
+        throw 'Nope';
+      }
+    });
+
+    try {
+      oracledb.fetchAsString = foo;
+    } catch(err) {
+      console.log(err);
+    } finally {
+      oracledb.fetchAsString = []; // restore
+    }
+  }); // 171.2
+
+  it.skip('171.3 data bind', async () => {
+    let conn;
+    try {
+      conn = await oracledb.getConnection(dbconfig);
+
+      let tableName = "nodb_tab_171_3";
+      let proc = "BEGIN \n" +
+                 "    DECLARE \n" +
+                 "        e_table_missing EXCEPTION; \n" +
+                 "        PRAGMA EXCEPTION_INIT(e_table_missing, -00942); \n" +
+                 "    BEGIN \n" +
+                 "        EXECUTE IMMEDIATE('DROP TABLE " + tableName + " PURGE'); \n" +
+                 "    EXCEPTION \n" +
+                 "        WHEN e_table_missing \n" +
+                 "        THEN NULL; \n" +
+                 "    END; \n" +
+                 "    EXECUTE IMMEDIATE (' \n" +
+                 "        CREATE TABLE " + tableName + " ( \n" +
+                 "            id      NUMBER, \n" +
+                 "            name    VARCHAR2(20) \n" +
+                 "        ) \n" +
+                 "    '); \n" +
+                 "END; ";
+      await conn.execute(proc);
+
+      let sqlInsert = "INSERT INTO " + tableName + " VALUES (:id, :nm)";
+      let bindVar = [2, 'Alison'];
+      Object.defineProperty(bindVar, '0', {
+        get: function() {
+          throw 'Nope';
+        }
+      });
+      await conn.execute(sqlInsert, bindVar);
+      
+      let sqlDrop = "DROP TABLE " + tableName + " PURGE";
+      await conn.execute(sqlDrop);
+
+    } catch(err) {
+      should.not.exist(err);
+    } finally {
+      if (conn) {
+        try {
+          await conn.close();
+        } catch(err) {
+          should.not.exist(err);
+        }
+      }
+    }
+  }); // 171.3
+});

test/list.txt

@@ -3631,7 +3631,7 @@ Overview of node-oracledb functional tests
     139.1 columns fetched from REF CURSORS can be mapped by fetchInfo settings
     139.2 fetchAsString takes effect as well
 
-  140. v8Getter.js
+140. jsObjectGetter1.js
     140.1 Negative: overwrite the getter() function of bind in objects
         140.1.1 ProcessBindsByName()
         140.1.2 ProcessBindsByPos()
@@ -4224,8 +4224,13 @@ Overview of node-oracledb functional tests
     170.8 works with poolAlias
     170.9 works with and without poolAlias
     170.10 Negative - try to modify read-only property pool.status
-    171.11 drainTime = 0
-    171.12 drainTime = -3
-    171.13 drainTime = NaN
-    171.14 draining a pool will not block the other pool
-    171.15 draining a pool will not block another aliased pool
+    170.11 drainTime = 0
+    170.12 drainTime = -3
+    170.13 drainTime = NaN
+    170.14 draining a pool will not block the other pool
+    170.15 draining a pool will not block another aliased pool
+
+171. jsObjectGetter2.js
+    171.1 oracledb.fetchAsBuffer
+    171.2 oracledb.fetchAsString
+    171.3 data bind

test/opts/mocha.opts

@@ -196,3 +196,4 @@ test/soda3.js
 test/sodaCallback.js
 
 test/soda4.js
+test/jsObjectGetter2.js

test/poolDrain.js

@@ -198,7 +198,7 @@ describe('170. poolDrain.js', () => {
     }
   }); // 170.10
 
-  it('171.11 drainTime = 0', async () => {
+  it('170.11 drainTime = 0', async () => {
     try {
       let pool = await oracledb.createPool(settings);
 
@@ -214,7 +214,7 @@ describe('170. poolDrain.js', () => {
     }
   });
 
-  it('171.12 drainTime = -3', async () => {
+  it('170.12 drainTime = -3', async () => {
     try {
       let pool = await oracledb.createPool(settings);
 
@@ -231,7 +231,7 @@ describe('170. poolDrain.js', () => {
     }
   });
 
-  it('171.13 drainTime = NaN', async () => {
+  it('170.13 drainTime = NaN', async () => {
     try {
       let pool = await oracledb.createPool(settings);
 
@@ -248,7 +248,7 @@ describe('170. poolDrain.js', () => {
     }
   });
 
-  it('171.14 draining a pool will not block the other pool', async () => {
+  it('170.14 draining a pool will not block the other pool', async () => {
     try {
       let pool_1 = await oracledb.createPool(settings);
       let pool_2 = await oracledb.createPool(settings);
@@ -271,7 +271,7 @@ describe('170. poolDrain.js', () => {
     }
   });
 
-  it('171.15 draining a pool will not block another aliased pool', async () => {
+  it('170.15 draining a pool will not block another aliased pool', async () => {
     try {
       let pool_1 = await oracledb.createPool(settings);
       let cred = {