Skip to content

Commit faa5903

Browse files
committed
Initial test and documentation updates
1 parent 43d0e51 commit faa5903

File tree

4 files changed

+5
-17
lines changed

4 files changed

+5
-17
lines changed

doc/src/api_manual/connection.rst

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1399,15 +1399,6 @@ Connection Methods
13991399
It is only present if a DML statement was executed.
14001400

14011401
Due to Node.js type limitations, the largest value shown will be 232 - 1, even if more rows were affected. Larger values will wrap.
1402-
* - ``warning``
1403-
- Object
1404-
- .. _execmanywarning:
1405-
1406-
This property provides an :ref:`error <errorobj>` object that gives information about any database warnings (such as PL/SQL compilation warnings) that were generated during the last call to :meth:`connection.executeMany()`.
1407-
1408-
See :ref:`plsqlcompwarnings` for more information.
1409-
1410-
.. versionadded:: 6.3
14111402

14121403
.. method:: connection.getDbObjectClass()
14131404

doc/src/release_notes.rst

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@ Common Changes
1616
#) Added a :ref:`warning <execwarning>` property to the
1717
:ref:`result <resultobject>` object for database warnings (such as PL/SQL
1818
compilation warnings) that are generated by calls to
19-
:meth:`connection.execute()`. Also, added the
20-
:ref:`warning <execmanywarning>` property to the
21-
:ref:`result <resultobjproperties>` object of
22-
:meth:`connection.executeMany()`.
19+
:meth:`connection.execute()`.
2320

2421
#) Added a :attr:`connection.warning` property for warnings (such as the
2522
password being in the grace period) that are generated during connection.

test/list.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,7 @@ Overview of node-oracledb functional tests
940940
63.1 nested execute() functions
941941

942942
64. sqlWithWarnings.js
943-
64.1 test case offered by GitHub user
943+
64.1 SQL - Success With Info
944944
64.1.1 Executes an aggregate query which causes warnings
945945
64.2 PL/SQL - Success With Info
946946
64.2.1 Execute SQL Statement to create PLSQL procedure with warnings

test/sqlWithWarnings.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* table will result in warnings (OCI_SUCCESS_WITH_INFO).
3232
*
3333
*****************************************************************************/
34-
"use strict";
34+
'use strict';
3535

3636
const oracledb = require('oracledb');
3737
const assert = require('assert');
@@ -48,7 +48,7 @@ describe('64. sqlWithWarnings.js', function() {
4848
await connection.close();
4949
});
5050

51-
describe('64.1 test case offered by GitHub user', function() {
51+
describe('64.1 SQL - Success With Info', function() {
5252

5353
const tableName = "nodb_aggregate";
5454

@@ -102,7 +102,7 @@ describe('64. sqlWithWarnings.js', function() {
102102

103103
it('64.2.1 Execute SQL Statement to create PLSQL procedure with warnings', async function() {
104104
assert.strictEqual(typeof connection, "object");
105-
await connection.execute (plsqlWithWarning);
105+
await connection.execute(plsqlWithWarning);
106106
}); // 64.2.1
107107

108108
}); // 64.2

0 commit comments

Comments
 (0)