Fixed bug that may cause runtime issues in some JavaScript frameworks

Author: sharadraju

doc/src/release_notes.rst

@@ -20,6 +20,11 @@ Common Changes
 #)  Fixed bug that may cause runtime issues in some JavaScript frameworks.
     See `Issue #1706 <https://github.com/oracle/node-oracledb/issues/1706>`__.
 
+Thin Mode Changes
++++++++++++++++++
+
+#) Fixed bug that fails to throw an error, when fetching data greater
+   than the ``maxSize`` property of outbinds in Oracle Database 12.1. 
 
 node-oracledb `v6.7.0 <https://github.com/oracle/node-oracledb/compare/v6.6.0...v6.7.0>`__ (18 Nov 2024)
 ---------------------------------------------------------------------------------------------------------

lib/thin/protocol/messages/withData.js

@@ -698,7 +698,7 @@ class MessageWithData extends Message {
       // conversion requested if maxSize is not multiplied by the
       // bufferSizeFactor
       if (variable.type._csfrm === constants.CSFRM_NCHAR) {
-        maxSize *= variable.type._bufferSizeFactor;
+        maxSize = Math.min(maxSize * variable.type._bufferSizeFactor, constants.TNS_MAX_LONG_LENGTH);
       }
       if ([constants.TNS_DATA_TYPE_ROWID, constants.TNS_DATA_TYPE_UROWID].includes(oraTypeNum)) {
         oraTypeNum = constants.TNS_DATA_TYPE_VARCHAR;
@@ -726,11 +726,9 @@ class MessageWithData extends Message {
       // expects that and complains if any other value is sent!
       buf.writeUInt8(0);
       buf.writeUInt8(0);
-      if (maxSize > buf.caps.maxStringSize) {
-        buf.writeUB4(constants.TNS_MAX_LONG_LENGTH);
-      } else {
-        buf.writeUB4(maxSize);
-      }
+
+      // Write the max buffer size
+      buf.writeUB4(maxSize);
 
       if (variable.isArray) {
         buf.writeUB4(variable.maxArraySize);