Use cloudprovider.NotImplemented error (#158)

Fixes: #64

Author: prydie

pkg/oci/instances.go

@@ -167,14 +167,15 @@ func (cp *CloudProvider) InstanceTypeByProviderID(ctx context.Context, providerI
 // AddSSHKeyToAllInstances adds an SSH public key as a legal identity for all instances
 // expected format for the key is standard ssh-keygen format: <protocol> <blob>
 func (cp *CloudProvider) AddSSHKeyToAllInstances(ctx context.Context, user string, keyData []byte) error {
-	return errors.New("unimplemented")
+	return cloudprovider.NotImplemented
 }
 
 // CurrentNodeName returns the name of the node we are currently running on
 // On most clouds (e.g. GCE) this is the hostname, so we provide the hostname
 func (cp *CloudProvider) CurrentNodeName(ctx context.Context, hostname string) (types.NodeName, error) {
 	glog.V(4).Infof("CurrentNodeName(%q) called", hostname)
-	return "", errors.New("unimplemented")
+	return "", cloudprovider.NotImplemented
+
 }
 
 // InstanceExistsByProviderID returns true if the instance for the given

pkg/oci/zones.go

@@ -16,13 +16,12 @@ package oci
 
 import (
 	"context"
-	"errors"
 	"strings"
 
-	"github.com/oracle/oci-cloud-controller-manager/pkg/oci/util"
-
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/kubernetes/pkg/cloudprovider"
+
+	"github.com/oracle/oci-cloud-controller-manager/pkg/oci/util"
 )
 
 var _ cloudprovider.Zones = &CloudProvider{}
@@ -40,7 +39,7 @@ func mapAvailabilityDomainToFailureDomain(AD string) string {
 // GetZone returns the Zone containing the current failure zone and locality
 // region that the program is running in.
 func (cp *CloudProvider) GetZone(ctx context.Context) (cloudprovider.Zone, error) {
-	return cloudprovider.Zone{}, errors.New("unimplemented")
+	return cloudprovider.Zone{}, cloudprovider.NotImplemented
 }
 
 // GetZoneByProviderID returns the Zone containing the current zone and