Fix panic when EnsureLoadBalancer() with 0 nodes (#177)

Fixes: #176

Author: prydie

pkg/oci/load_balancer.go

@@ -582,6 +582,9 @@ func loadBalancerToStatus(lb *loadbalancer.LoadBalancer) (*v1.LoadBalancerStatus
 
 	ingress := []v1.LoadBalancerIngress{}
 	for _, ip := range lb.IpAddresses {
+		if ip.IpAddress == nil {
+			continue // should never happen but appears to when EnsureLoadBalancer is called with 0 nodes.
+		}
 		ingress = append(ingress, v1.LoadBalancerIngress{IP: *ip.IpAddress})
 	}
 	return &v1.LoadBalancerStatus{Ingress: ingress}, nil

pkg/oci/load_balancer_spec.go

@@ -215,9 +215,6 @@ func getPorts(svc *v1.Service) map[string]portSpec {
 }
 
 func getBackends(nodes []*v1.Node, nodePort int32) []loadbalancer.BackendDetails {
-	if len(nodes) == 0 {
-		return nil
-	}
 	backends := make([]loadbalancer.BackendDetails, len(nodes))
 	for i, node := range nodes {
 		backends[i] = loadbalancer.BackendDetails{

pkg/oci/load_balancer_spec_test.go

@@ -67,6 +67,7 @@ func TestNewLBSpecSuccess(t *testing.T) {
 				},
 				BackendSets: map[string]loadbalancer.BackendSetDetails{
 					"TCP-80": loadbalancer.BackendSetDetails{
+						Backends: []loadbalancer.BackendDetails{},
 						HealthChecker: &loadbalancer.HealthCheckerDetails{
 							Protocol: common.String("HTTP"),
 							Port:     common.Int(10256),
@@ -120,6 +121,7 @@ func TestNewLBSpecSuccess(t *testing.T) {
 				},
 				BackendSets: map[string]loadbalancer.BackendSetDetails{
 					"TCP-80": loadbalancer.BackendSetDetails{
+						Backends: []loadbalancer.BackendDetails{},
 						HealthChecker: &loadbalancer.HealthCheckerDetails{
 							Protocol: common.String("HTTP"),
 							Port:     common.Int(10256),
@@ -174,6 +176,7 @@ func TestNewLBSpecSuccess(t *testing.T) {
 				},
 				BackendSets: map[string]loadbalancer.BackendSetDetails{
 					"TCP-80": loadbalancer.BackendSetDetails{
+						Backends: []loadbalancer.BackendDetails{},
 						HealthChecker: &loadbalancer.HealthCheckerDetails{
 							Protocol: common.String("HTTP"),
 							Port:     common.Int(10256),
@@ -227,6 +230,7 @@ func TestNewLBSpecSuccess(t *testing.T) {
 				},
 				BackendSets: map[string]loadbalancer.BackendSetDetails{
 					"TCP-80": loadbalancer.BackendSetDetails{
+						Backends: []loadbalancer.BackendDetails{},
 						HealthChecker: &loadbalancer.HealthCheckerDetails{
 							Protocol: common.String("HTTP"),
 							Port:     common.Int(10256),