[OKE-36786] NodeUnpublish should return success when path is not present

Author: YashasG98

pkg/csi/driver/bv_node.go

@@ -664,6 +664,10 @@ func (d BlockVolumeNodeDriver) NodeUnpublishVolume(ctx context.Context, req *csi
 	isRawBlockVolume, rbvCheckErr := hostUtil.PathIsDevice(req.TargetPath)
 
 	if rbvCheckErr != nil {
+		if alreadyDeletedPathCheck(rbvCheckErr) {
+			logger.With(zap.Error(rbvCheckErr)).With("mountPath", req.TargetPath).Warn("mount point not found, marking unpublish success")
+			return &csi.NodeUnpublishVolumeResponse{}, nil
+		}
 		logger.With(zap.Error(rbvCheckErr)).Error("failed to check if it is a device file")
 		return nil, status.Errorf(codes.Internal, rbvCheckErr.Error())
 	}
@@ -751,6 +755,13 @@ func getDevicePathAndAttachmentType(path []string) (string, string, error) {
 	return "", "", errors.New("unable to determine the attachment type")
 }
 
+func alreadyDeletedPathCheck(err error) bool {
+	if err == nil {
+		return false
+	}
+	return strings.Contains(err.Error(), "does not exist")
+}
+
 // NodeGetCapabilities returns the supported capabilities of the node server
 func (d BlockVolumeNodeDriver) NodeGetCapabilities(ctx context.Context, req *csi.NodeGetCapabilitiesRequest) (*csi.NodeGetCapabilitiesResponse, error) {
 	var nscaps []*csi.NodeServiceCapability

pkg/csi/driver/bv_node_test.go

@@ -15,6 +15,7 @@
 package driver
 
 import (
+	"fmt"
 	"testing"
 )
 
@@ -81,3 +82,33 @@ func Test_getDevicePathAndAttachmentType(t *testing.T) {
 		})
 	}
 }
+
+func Test_alreadyDeletedPathCheck(t *testing.T) {
+	type args struct {
+		err error
+	}
+	tests := []struct {
+		name string
+		args args
+		want bool
+	}{
+		{
+			"Error contains 'does not exist'",
+			args{err: fmt.Errorf("path /some/path does not exist")},
+			true,
+		},
+		{
+			"Nil error",
+			args{err: nil},
+			false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := alreadyDeletedPathCheck(tt.args.err)
+			if got != tt.want {
+				t.Errorf("alreadyDeletedPathCheck() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}