Skip to content

Commit 78ccfc1

Browse files
authored
Merge branch 'oracle:master' into yutpeng/secondar-vnic
2 parents 0f9ce4e + fca4492 commit 78ccfc1

File tree

6,004 files changed

+539305
-129909
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

6,004 files changed

+539305
-129909
lines changed

.github/workflows/makefile.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- name: Set up Go 1.x
1313
uses: actions/setup-go@v2
1414
with:
15-
go-version: 1.19
15+
go-version: '1.20'
1616
id: go
1717

1818
- name: Check out code into the Go module directory

CONTRIBUTING.md

Lines changed: 58 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,70 @@
1-
# Contributing to the OCI Cloud Controller Manager
1+
# Contributing to this repository
22

3-
*Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved.*
3+
We welcome your contributions! There are multiple ways to contribute.
44

5-
## Guidelines to raise a PR
5+
## Opening issues
66

7-
### Contributor Agreement
7+
For bugs or enhancement requests, please file a GitHub issue unless it's
8+
security related. When filing a bug remember that the better written the bug is,
9+
the more likely it is to be fixed. If you think you've found a security
10+
vulnerability, do not raise a GitHub issue and follow the instructions in our
11+
[security policy](./SECURITY.md).
812

9-
Pull requests can be made under
10-
[The Oracle Contributor Agreement](https://www.oracle.com/technetwork/community/oca-486395.html)
11-
(OCA).
12-
For pull requests to be accepted, the bottom of
13-
your commit message must have the following line using your name and
14-
e-mail address as it appears in the OCA Signatories list.
15-
```
13+
## Contributing code
14+
15+
We welcome your code contributions. Before submitting code via a pull request,
16+
you will need to have signed the [Oracle Contributor Agreement][OCA] (OCA) and
17+
your commits need to include the following line using the name and e-mail
18+
address you used to sign the OCA:
19+
20+
```text
1621
Signed-off-by: Your Name <[email protected]>
1722
```
18-
This can be automatically added to pull requests by committing with:
19-
```
23+
24+
This can be automatically added to pull requests by committing with `--sign-off`
25+
or `-s`, e.g.
26+
27+
```text
2028
git commit --signoff
2129
```
22-
**Only pull requests from committers that can be verified as having
23-
signed the OCA can be accepted.**
30+
31+
Only pull requests from committers that can be verified as having signed the OCA
32+
can be accepted.
33+
34+
## Pull request process
35+
36+
1. Ensure there is an issue created to track and discuss the fix or enhancement
37+
you intend to submit.
38+
1. Fork this repository.
39+
1. Create a branch in your fork to implement the changes. We recommend using
40+
the issue number as part of your branch name, e.g. `1234-fixes`.
41+
1. Ensure that any documentation is updated with the changes that are required
42+
by your change.
43+
1. Ensure that any samples are updated if the base image has been changed.
44+
1. Submit the pull request. *Do not leave the pull request blank*. Explain exactly
45+
what your changes are meant to do and provide simple steps on how to validate.
46+
your changes. Ensure that you reference the issue you created as well.
47+
1. We will assign the pull request to 2-3 people for review before it is merged.
2448

2549
### Commit Message
26-
* The commits message should prefix "External-ccm:"
27-
* All commits should be squashed to a single commit before merging
2850

29-
### Best Practices
51+
* The commits message should prefix "External-ccm:".
52+
* All commits should be squashed to a single commit before merging.
53+
54+
### Best Practices:
55+
3056
* Follow the development guidelines [here](docs/development.md)
31-
* govet, golint, gofmt should pass on the PR
32-
* make targets "build" and "test" should be successful on the PR
33-
* E2E should be run on a self managed test cluster, you will have to create a test cluster with the image generated from your changes. Please follow E2E guide [here](test/e2e/cloud-provider-oci/README.md)
34-
* E2E tests should pass on 3 versions of kubernetes currently supported by the repo
57+
* `govet`, `golint`, `gofmt` should pass on the PR
58+
* Make targets "build" and "test" should be successful on the PR
59+
* E2E should be run on a self managed test cluster, you will have to create a test
60+
cluster with the image generated from your changes.
61+
Please follow E2E guide [here](test/e2e/cloud-provider-oci/README.md)
62+
* E2E tests should pass on 3 versions of kubernetes currently supported by the repo.
63+
64+
## Code of conduct
65+
66+
Follow the [Golden Rule](https://en.wikipedia.org/wiki/Golden_Rule). If you'd
67+
like more specific guidelines, see the [Contributor Covenant Code of Conduct][COC].
68+
69+
[OCA]: https://oca.opensource.oracle.com
70+
[COC]: https://www.contributor-covenant.org/version/1/4/code-of-conduct/

Dockerfile

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
ARG CI_IMAGE_REGISTRY
1616

17-
FROM golang:1.18.5 as builder
17+
FROM golang:1.21.5 as builder
1818

1919
ARG COMPONENT
2020

@@ -27,14 +27,22 @@ WORKDIR $SRC
2727

2828
RUN COMPONENT=${COMPONENT} make clean build
2929

30-
FROM oraclelinux:7-slim
30+
FROM oraclelinux:8-slim
3131

3232
COPY --from=0 /go/src/github.com/oracle/oci-cloud-controller-manager/dist/* /usr/local/bin/
3333
COPY --from=0 /go/src/github.com/oracle/oci-cloud-controller-manager/image/* /usr/local/bin/
3434

35-
RUN yum install -y util-linux \
36-
&& yum install -y e2fsprogs \
37-
&& yum install -y xfsprogs \
38-
&& yum clean all
35+
RUN microdnf -y install util-linux e2fsprogs xfsprogs python2 && \
36+
microdnf update && \
37+
microdnf clean all
3938

40-
COPY --from=0 /go/src/github.com/oracle/oci-cloud-controller-manager/dist/* /usr/local/bin/
39+
COPY scripts/encrypt-mount /sbin/encrypt-mount
40+
COPY scripts/encrypt-umount /sbin/encrypt-umount
41+
COPY scripts/rpm-host /sbin/rpm-host
42+
COPY scripts/chroot-bash /sbin/chroot-bash
43+
RUN chmod 755 /sbin/encrypt-mount
44+
RUN chmod 755 /sbin/encrypt-umount
45+
RUN chmod 755 /sbin/rpm-host
46+
RUN chmod 755 /sbin/chroot-bash
47+
48+
COPY --from=0 /go/src/github.com/oracle/oci-cloud-controller-manager/dist/* /usr/local/bin/

Dockerfile_arm_all

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ARG CI_IMAGE_REGISTRY
22

3-
FROM golang:1.18.5 as builder
3+
FROM golang:1.21.5 as builder
44

55
ARG COMPONENT
66

@@ -14,11 +14,19 @@ WORKDIR $SRC
1414

1515
RUN ARCH=arm make clean build-arm-all
1616

17-
FROM arm64v8/oraclelinux:7-slim
17+
FROM arm64v8/oraclelinux:8-slim
1818

19-
RUN yum install -y util-linux \
20-
&& yum install -y e2fsprogs \
21-
&& yum clean all
22-
\
19+
RUN microdnf -y install util-linux e2fsprogs xfsprogs python2 && \
20+
microdnf update && \
21+
microdnf clean all
2322

24-
COPY --from=0 /go/src/github.com/oracle/oci-cloud-controller-manager/dist/arm/* /usr/local/bin/
23+
COPY scripts/encrypt-mount /sbin/encrypt-mount
24+
COPY scripts/encrypt-umount /sbin/encrypt-umount
25+
COPY scripts/rpm-host /sbin/rpm-host
26+
COPY scripts/chroot-bash /sbin/chroot-bash
27+
RUN chmod 755 /sbin/encrypt-mount
28+
RUN chmod 755 /sbin/encrypt-umount
29+
RUN chmod 755 /sbin/rpm-host
30+
RUN chmod 755 /sbin/chroot-bash
31+
32+
COPY --from=0 /go/src/github.com/oracle/oci-cloud-controller-manager/dist/arm/* /usr/local/bin/

LICENSE

Lines changed: 0 additions & 202 deletions
This file was deleted.

0 commit comments

Comments
 (0)