Nil check dereferences of non-mandatory SDK fields (#185)

Guard against theoretical panics when accessing non-mandatory OCI Go SDK fields.

Author: prydie

pkg/oci/client/compute.go

@@ -111,12 +111,18 @@ func (c *client) GetPrimaryVNICForInstance(ctx context.Context, compartmentID, i
 				continue
 			}
 
+			if attachment.VnicId == nil {
+				// Should never happen but lets be extra cautious as field is non-mandatory in OCI API.
+				glog.Errorf("VNIC attachment %q for instance %q is attached but has no VNIC ID", *attachment.Id, instanceID)
+				continue
+			}
+
 			// TODO(apryde): Cache map[instanceID]primaryVNICID.
 			vnic, err := c.getVNIC(ctx, *attachment.VnicId)
 			if err != nil {
 				return nil, err
 			}
-			if *vnic.IsPrimary {
+			if vnic.IsPrimary != nil && *vnic.IsPrimary {
 				return vnic, nil
 			}
 		}
@@ -157,6 +163,12 @@ func (c *client) GetInstanceByNodeName(ctx context.Context, compartmentID, vcnID
 				continue
 			}
 
+			if attachment.VnicId == nil {
+				// Should never happen but lets be extra cautious as field is non-mandatory in OCI API.
+				glog.Errorf("VNIC attachment %q for instance %q is attached but has no VNIC ID", *attachment.Id, nodeName)
+				continue
+			}
+
 			vnic, err := c.getVNIC(ctx, *attachment.VnicId)
 			if err != nil {
 				return nil, err