Fixes #242 implements intances.InstanceShutdownByProviderID (#295)

Author: jhorwit2

pkg/cloudprovider/providers/oci/instances.go

@@ -180,5 +180,16 @@ func (cp *CloudProvider) InstanceExistsByProviderID(ctx context.Context, provide
 
 // InstanceShutdownByProviderID returns true if the instance is shutdown in cloudprovider.
 func (cp *CloudProvider) InstanceShutdownByProviderID(ctx context.Context, providerID string) (bool, error) {
-	return false, cloudprovider.NotImplemented
+	cp.logger.With("instanceID", providerID).Debug("Checking instance is stopped by provider id")
+	instanceID, err := MapProviderIDToInstanceID(providerID)
+	if err != nil {
+		return false, err
+	}
+
+	instance, err := cp.client.Compute().GetInstance(ctx, instanceID)
+	if err != nil {
+		return false, err
+	}
+
+	return client.IsInstanceInStoppedState(instance), nil
 }

pkg/oci/client/client_test.go

@@ -57,6 +57,41 @@ func TestInstanceTerminalState(t *testing.T) {
 	}
 }
 
+func TestInstanceStoppedState(t *testing.T) {
+	testCases := map[string]struct {
+		state    core.InstanceLifecycleStateEnum
+		expected bool
+	}{
+		"not stopped - running": {
+			state:    core.InstanceLifecycleStateRunning,
+			expected: false,
+		},
+		"not stopped - terminated": {
+			state:    core.InstanceLifecycleStateTerminated,
+			expected: false,
+		},
+		"is stopped - stopped": {
+			state:    core.InstanceLifecycleStateStopped,
+			expected: true,
+		},
+		"is stopped - stopping": {
+			state:    core.InstanceLifecycleStateStopping,
+			expected: true,
+		},
+	}
+
+	for name, tc := range testCases {
+		t.Run(name, func(t *testing.T) {
+			result := IsInstanceInStoppedState(&core.Instance{
+				LifecycleState: tc.state,
+			})
+			if result != tc.expected {
+				t.Errorf("IsInstanceInStoppedState(%q) = %v ; wanted %v", tc.state, result, tc.expected)
+			}
+		})
+	}
+}
+
 type mockComputeClient struct{}
 
 type mockVirtualNetworkClient struct{}

pkg/oci/client/compute.go

@@ -232,6 +232,12 @@ func IsInstanceInTerminalState(instance *core.Instance) bool {
 		instance.LifecycleState == core.InstanceLifecycleStateTerminating
 }
 
+// IsInstanceInStoppedState returns true if the instance is in a stopped or stopping state, false otherwise.
+func IsInstanceInStoppedState(instance *core.Instance) bool {
+	return instance.LifecycleState == core.InstanceLifecycleStateStopped ||
+		instance.LifecycleState == core.InstanceLifecycleStateStopping
+}
+
 func getNonTerminalInstances(instances []core.Instance) []core.Instance {
 	var result []core.Instance
 	for _, instance := range instances {