Skip to content

Commit 9e7e28b

Browse files
Addressed review comments
1 parent 39e0cd2 commit 9e7e28b

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

cmd/oci-csi-controller-driver/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ func main() {
5555
}
5656
logger.With("endpoint", csiOptions.Endpoint).Infof("Starting controller driver go routine.")
5757
go csicontrollerdriver.StartControllerDriver(csiOptions, driver.BV)
58-
go csicontrollerdriver.StartControllerDriver(csiOptions, driver.FSS) //TODO: Need to check with Mrunal to be it here
58+
go csicontrollerdriver.StartControllerDriver(csiOptions, driver.FSS)
5959
<-stopCh
6060
}

pkg/cloudprovider/providers/oci/config/config.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@
1515
package config
1616

1717
import (
18-
"github.com/oracle/oci-cloud-controller-manager/pkg/oci/instance/metadata"
1918
"io"
2019
"os"
2120

21+
"github.com/oracle/oci-cloud-controller-manager/pkg/oci/instance/metadata"
22+
2223
"github.com/oracle/oci-go-sdk/v65/common"
2324
"github.com/oracle/oci-go-sdk/v65/common/auth"
2425
"github.com/pkg/errors"
@@ -122,7 +123,7 @@ type TagConfig struct {
122123
DefinedTags map[string]map[string]interface{} `yaml:"defined"`
123124
}
124125

125-
// InitialTags initialTags are optional tags to apply to all LBs, BVs, File systems, Mount Targets and Exports provisioned in the cluster
126+
// InitialTags are optional tags to apply to all LBs, BVs, File systems, Mount Targets and Exports provisioned in the cluster
126127
type InitialTags struct {
127128
LoadBalancer *TagConfig `yaml:"loadBalancer"`
128129
BlockVolume *TagConfig `yaml:"blockVolume"`

pkg/csi/driver/fss_controller_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,6 @@ type MockFSSProvisionerClient struct {
174174
Storage *MockFileStorageClient
175175
}
176176

177-
// func (m MockFSSProvisionerClient) ContainerEngine() client.ContainerEngineInterface {
178-
// return &MockContainerEngineClient{}
179-
// }
180-
181177
func (m MockFSSProvisionerClient) Compute() client.ComputeInterface {
182178
return &MockComputeClient{}
183179
}

0 commit comments

Comments
 (0)