Skip to content

Commit b2d36e8

Browse files
committed
E2E fixes, added checks for taints before proceeding with tests
1 parent 53c5ef9 commit b2d36e8

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

test/e2e/cloud-provider-oci/fss.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ var _ = Describe("FSS in-transit encryption test", func() {
4444
})
4545

4646
func TestEncryptionType(f *framework.CloudProviderFramework) {
47+
checkNodeAvailability(f)
4748
pvcJig := framework.NewPVCTestJig(f.ClientSet, "csi-fss-e2e-test-intransit")
4849
pv := pvcJig.CreatePVorFailFSS(f.Namespace.Name, setupF.VolumeHandle, "true")
4950
pvc := pvcJig.CreateAndAwaitPVCOrFailFSS(f.Namespace.Name, pv.Name, "50Gi", nil)
@@ -73,9 +74,9 @@ var _ = Describe("Multiple Pods FSS test", func() {
7374
})
7475
})
7576

76-
func checkNodeAvailability(f *framework.CloudProviderFramework){
77+
func checkNodeAvailability(f *framework.CloudProviderFramework) {
7778
pvcJig := framework.NewPVCTestJig(f.ClientSet, "csi-fss-e2e-test")
78-
nodeList, err := pvcJig.KubeClient.CoreV1().Nodes().List(context.Background(),v12.ListOptions{LabelSelector: "oke.oraclecloud.com/e2e.oci-fss-util"})
79+
nodeList, err := pvcJig.KubeClient.CoreV1().Nodes().List(context.Background(), v12.ListOptions{LabelSelector: "oke.oraclecloud.com/e2e.oci-fss-util"})
7980
if err != nil {
8081
framework.Logf("Error getting applicable nodes: %v", err)
8182
}

test/e2e/framework/pvc_util.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,10 +1046,16 @@ func (j *PVCTestJig) CheckDataPersistenceWithDeployment(pvcName string, ns strin
10461046
schedulableNodeFound := false
10471047

10481048
for _, node := range nodes.Items {
1049+
taintIsMaster := false
10491050
if node.Spec.Unschedulable == false {
1050-
schedulableNodeFound = true
1051-
nodeSelectorLabels = node.Labels
1052-
break
1051+
for _, taint := range node.Spec.Taints {
1052+
taintIsMaster = taint.Key == "node-role.kubernetes.io/master"
1053+
}
1054+
if !taintIsMaster {
1055+
schedulableNodeFound = true
1056+
nodeSelectorLabels = node.Labels
1057+
break
1058+
}
10531059
}
10541060
}
10551061

0 commit comments

Comments
 (0)