Do not record events for failure to acquire lock for lb sync

Author: l-technicore

pkg/cloudprovider/providers/oci/load_balancer.go

@@ -52,9 +52,10 @@ const (
 	NetworkLoadBalancingPolicyTwoTuple   = "TWO_TUPLE"
 	NetworkLoadBalancingPolicyThreeTuple = "THREE_TUPLE"
 	NetworkLoadBalancingPolicyFiveTuple  = "FIVE_TUPLE"
-	LbOperationAlreadyExistsFmt          = "An operation for the %s: %s already exists."
 )
 
+var LbOperationAlreadyExists = errors.New("An operation for the service is already in progress.")
+
 // DefaultLoadBalancerBEProtocol defines the default protocol for load
 // balancer listeners created by the CCM.
 const DefaultLoadBalancerBEProtocol = "TCP"
@@ -491,7 +492,7 @@ func (cp *CloudProvider) EnsureLoadBalancer(ctx context.Context, clusterName str
 	loadBalancerService := fmt.Sprintf("%s/%s", service.Namespace, service.Name)
 	if acquired := cp.lbLocks.TryAcquire(loadBalancerService); !acquired {
 		logger.Error("Could not acquire lock for Ensuring Load Balancer")
-		return nil, errors.Errorf(LbOperationAlreadyExistsFmt, loadBalancerType, loadBalancerService)
+		return nil, LbOperationAlreadyExists
 	}
 	defer cp.lbLocks.Release(loadBalancerService)
 
@@ -1149,7 +1150,7 @@ func (cp *CloudProvider) UpdateLoadBalancer(ctx context.Context, clusterName str
 	loadBalancerService := fmt.Sprintf("%s/%s", service.Namespace, service.Name)
 	if acquired := cp.lbLocks.TryAcquire(loadBalancerService); !acquired {
 		logger.Error("Could not acquire lock for Updating Load Balancer")
-		return errors.Errorf(LbOperationAlreadyExistsFmt, loadBalancerType, loadBalancerService)
+		return LbOperationAlreadyExists
 	}
 	defer cp.lbLocks.Release(loadBalancerService)
 
@@ -1316,7 +1317,7 @@ func (cp *CloudProvider) EnsureLoadBalancerDeleted(ctx context.Context, clusterN
 	loadBalancerService := fmt.Sprintf("%s/%s", service.Namespace, service.Name)
 	if acquired := cp.lbLocks.TryAcquire(loadBalancerService); !acquired {
 		logger.Error("Could not acquire lock for Deleting Load Balancer")
-		return errors.Errorf(LbOperationAlreadyExistsFmt, loadBalancerType, loadBalancerService)
+		return LbOperationAlreadyExists
 	}
 	defer cp.lbLocks.Release(loadBalancerService)