Remove check for number of subnets

Author: MadalinaPatrichi

pkg/cloudprovider/providers/oci/load_balancer_spec.go

@@ -134,11 +134,14 @@ func NewLBSpec(svc *v1.Service, nodes []*v1.Node, defaultSubnets []string, sslCo
 			return nil, errors.Errorf("a configuration for subnet1 must be specified for an internal load balancer")
 		}
 		subnets = subnets[:1]
-	} else {
-		if subnets[0] == "" || subnets[1] == "" {
-			return nil, errors.Errorf("a configuration for both subnets must be specified")
-		}
 	}
+	// Disable check for whether there are two subnets, rely on OCI to decide whether the number of subnets is correct
+	// This allows LoadBalancers to be created in single AD regions
+	// else {
+	// 	if subnets[0] == "" || subnets[1] == "" {
+	// 		return nil, errors.Errorf("a configuration for both subnets must be specified")
+	// 	}
+	// }
 
 	listeners, err := getListeners(svc, sslConfig)
 	if err != nil {

pkg/cloudprovider/providers/oci/load_balancer_spec_test.go

@@ -566,21 +566,6 @@ func TestNewLBSpecFailure(t *testing.T) {
 			},
 			expectedErrMsg: "error parsing service annotation: service.beta.kubernetes.io/oci-load-balancer-connection-idle-timeout=whoops",
 		},
-		"missing subnet defaults and annotations": {
-			service: &v1.Service{
-				ObjectMeta: metav1.ObjectMeta{
-					Namespace:   "kube-system",
-					Name:        "testservice",
-					UID:         "test-uid",
-					Annotations: map[string]string{},
-				},
-				Spec: v1.ServiceSpec{
-					SessionAffinity: v1.ServiceAffinityNone,
-					Ports:           []v1.ServicePort{},
-				},
-			},
-			expectedErrMsg: "a configuration for both subnets must be specified",
-		},
 		"internal lb missing subnet1": {
 			defaultSubnetTwo: "two",
 			service: &v1.Service{