-
Notifications
You must be signed in to change notification settings - Fork 96
Description
Hello team,
First of all, thank you for maintaining the OCI CSI driver. I have been testing the deployment and noticed an issue that might cause confusion for users following the documentation.
Description:
When deploying the csi-oci-controller using the official manifests, the Deployment spec includes:
imagePullSecrets:
- name: image-pull-secretHowever:
• The referenced secret (image-pull-secret) does not exist by default.
• The images used (ghcr.io/oracle/cloud-provider-oci and registry.k8s.io/sig-storage/...) are public and do not require authentication.
• The documentation does not mention the need to create this secret or remove the reference.
This results in warnings like:
FailedToRetrieveImagePullSecret Unable to retrieve some image pull secrets (image-pull-secret); attempting to pull the image may not succeed.
and in practice the csi-oci-controller pods go into CrashLoopBackOff until the reference is removed or a dummy secret is created.
Steps to reproduce:
1. Deploy the OCI CSI driver manifests as documented.
2. Observe that the csi-oci-controller Deployment references image-pull-secret.
3. Since the secret does not exist, pods fail with FailedToRetrieveImagePullSecret and cannot start properly.
Expected behavior:
• Since the images are public, the manifests should not reference any imagePullSecrets by default.
• Alternatively, the documentation should clearly explain that either the reference must be removed, or a valid Docker registry secret must be created.
Proposed fix:
• Remove the imagePullSecrets section from the default manifests.
• Or document explicitly how to handle this (create a valid secret or remove the section).
Thanks