Skip to content

Commit 169b626

Browse files
committed
Updated release items
1 parent e02d345 commit 169b626

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

.github/workflows/release.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,12 @@ on:
1313
- "v*.*.*"
1414

1515
jobs:
16+
1617
build:
1718
runs-on: ubuntu-latest
19+
env:
20+
IMAGE_REGISTRY: ghcr.io/oracle
1821
steps:
19-
2022
- name: Checkout
2123
uses: actions/[email protected]
2224

GettingStarted.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ kubectl get pods --namespace native-ingress-controller-system --selector='app.ku
252252
Note: Use the correct namespace
253253

254254
### Getting Started with Ingress
255-
We can create the ingressclass using the sample ingressClass-file which will help setup the ingressClassParameter and ingressClass.
255+
We can create the IngressClass using the sample IngressClass file which will help set up the IngressClassParameter and IngressClass.
256256
We need to update the subnetId and compartmentId(Only if overriding values from Values.yaml) before executing the yaml.
257257
```
258258
apiVersion: "ingress.oraclecloud.com/v1beta1"
@@ -507,6 +507,9 @@ lb.ingress.oraclecloud.com/healthcheck-return-code
507507
lb.ingress.oraclecloud.com/healthcheck-response-regex
508508
lb.ingress.oraclecloud.com/healthcheck-force-plaintext
509509
```
510+
References:
511+
- Policy - https://docs.oracle.com/en-us/iaas/Content/Balance/Reference/lbpolicies.htm
512+
- Healthchecker - https://docs.oracle.com/en-us/iaas/api/#/en/loadbalancer/20170115/HealthChecker/
510513

511514
### Dependency management
512515
Module [vendoring](https://go.dev/ref/mod#vendoring) is used to manage 3d-party modules in the project.
@@ -524,8 +527,8 @@ All changes to those modules should be reflected in the remote VCS repository.
524527

525528
### Known Issues
526529
1. The loadbalancer has a limitation of 16 backend sets per load balancer. We create a backend set for every unique service and port combination. So if a customer has more such services they need to have new load balancers.
527-
2. Each service port is mapped to a load balancer listener. For SSL configuration customer can specify only one key pair per listener. Any conflicting declarations across ingress resources for same lister will throw a validation error.
528-
3. Any conflicting declarations for same backend set health checker and routing policy across ingress resources will throw a validation error.
530+
2. Each service port is mapped to a load balancer listener. For SSL configuration customer can specify only one key pair per listener which would be used for SSL termination. All the backend sets that are mapped to the listener will use the same issuer(CA Bundle) as the issuer of listener certificate. Any conflicting declarations across ingress resources for same listener will throw a validation error which will be logged in controller logs.
531+
3. Any conflicting declarations for same backend set health checker and routing policy across ingress resources will throw a validation error which will be logged in controller logs.
529532
4. For supporting ssl through kubernetes secrets, we generate respective certificates and ca bundles in certificate service. If we delete ingress resource, currently we only delete the load balancer resources.
530533
The certificates need to be cleared by the customer.
531534

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
IMAGE_REPO_NAME=oci-native-ingress-controller
99

1010
ifeq "$(REGISTRY)" ""
11-
REGISTRY ?= ghcr.io/oracle-samples
11+
REGISTRY ?= ghcr.io/oracle
1212
else
1313
REGISTRY ?= ${REGISTRY}
1414
endif

deploy/example/customresource/ingressclassparameter.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ kind: IngressClassParameters
99
metadata:
1010
name: ingressparms-cr-test
1111
spec:
12-
compartmentID: "ocid1.compartment.oc1..aaaaaaaauckenasusv5odnc4bqspi77hgnjeo6ydq33hidzadpkxyyyzzzz"
13-
subnetID: "ocid1.subnet.oc1.iad.aaaaaaaaxaq3szzikh7cb53arlkdgbi4wz4g73qpnuqhdhqckr2d5xyyyzzzz"
12+
compartmentId: "ocid1.compartment.oc1..aaaaaaaaxaq3szzikh7cb53arlkdgbi4wz4g73qpnuqhdhqckr2d5rvdffya"
13+
subnetId: "ocid1.subnet.oc1.iad.aaaaaaaauckenasusv5odnc4bqspi77hgnjeo6ydq33hidzadpkjvce7vkpa"
1414
loadBalancerName: "native-ic-lb"
1515
isPrivate: false
1616
maxBandwidthMbps: 400

0 commit comments

Comments
 (0)