fixed panic on no tls configuration for http2 annotated ingresses

piyush-tiwari · piyush-tiwari · commit 2bcb8ae29271 · 2024-07-15T18:40:00.000+05:30
diff --git a/pkg/loadbalancer/loadbalancer.go b/pkg/loadbalancer/loadbalancer.go
@@ -640,6 +640,10 @@ func (lbc *LoadBalancerClient) CreateListener(ctx context.Context, lbID string,
 	}
 
 	if listenerProtocol == util.ProtocolHTTP2 {
+		if sslConfig == nil {
+			return fmt.Errorf("no TLS configuration provided for a HTTP2 listener at port %d", listenerPort)
+		}
+		
 		sslConfig.CipherSuiteName = common.String(util.ProtocolHTTP2DefaultCipherSuite)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -640,6 +640,10 @@ func (lbc *LoadBalancerClient) CreateListener(ctx context.Context, lbID string,`
`640`	`640`	`}`
`641`	`641`
`642`	`642`	`if listenerProtocol == util.ProtocolHTTP2 {`
	`643`	`+ if sslConfig == nil {`
	`644`	`+ return fmt.Errorf("no TLS configuration provided for a HTTP2 listener at port %d", listenerPort)`
	`645`	`+ }`
	`646`	`+`
`643`	`647`	`sslConfig.CipherSuiteName = common.String(util.ProtocolHTTP2DefaultCipherSuite)`
`644`	`648`	`}`
`645`	`649`