(fix): Required parameter follows optional parameter

markharding · markharding · commit 9d0f2f0ae667 · 2023-06-13T09:33:34.000+01:00
diff --git a/src/Oracle/Oci/Common/HttpUtils.php b/src/Oracle/Oci/Common/HttpUtils.php
@@ -163,7 +163,7 @@ public static function attemptEncodeParam($value) // : string
      * @return mixed|null the value indicated by the parameter name, or null if not found
      * @throws InvalidArgumentException if the parameter does not exist and $required is true
      */
-    public static function orNull($params=[], $paramName, $required = false)
+    public static function orNull($params, $paramName, $required = false)
     {
         if (array_key_exists($paramName, $params)) {
             return $params[$paramName];

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ public static function attemptEncodeParam($value) // : string`
`163`	`163`	`* @return mixed\|null the value indicated by the parameter name, or null if not found`
`164`	`164`	`* @throws InvalidArgumentException if the parameter does not exist and $required is true`
`165`	`165`	`*/`
`166`		`- public static function orNull($params=[], $paramName, $required = false)`
	`166`	`+ public static function orNull($params, $paramName, $required = false)`
`167`	`167`	`{`
`168`	`168`	`if (array_key_exists($paramName, $params)) {`
`169`	`169`	`return $params[$paramName];`