Run pylint in venv (#2443)

fixes #2442

Author: Vladimir Kotal

dev/install-python-packages.sh

@@ -2,13 +2,7 @@
 
 python3 -m pip install --upgrade pip
 
-python3 -m pip install -r opengrok-tools/src/main/python/requirements.txt
-if [[ $? != 0 ]]; then
-	echo "cannot install Python requirement packages"
-	exit 1
-fi
-
-python3 -m pip install pep8 flake8 virtualenv pylint
+python3 -m pip install pep8 flake8 virtualenv
 if [[ $? != 0 ]]; then
 	echo "cannot install Python packages"
 	exit 1

opengrok-tools/pom.xml

@@ -140,29 +140,30 @@ Portions Copyright (c) 2017-2018, Chris Fraire <[email protected]>.
                         </goals>
                     </execution>
                     <execution>
-                        <id>Python lint</id>
+                        <id>generate python env</id>
                         <configuration>
-                            <executable>pylint</executable>
+                            <executable>python3</executable>
+                            <workingDirectory>${project.build.directory}</workingDirectory>
                             <arguments>
-                                <argument>-E</argument>
-                                <argument>${project.build.sourceDirectory}/opengrok_tools</argument>
-                                <argument>${project.build.directory}/setup.py</argument>
+                                <argument>-m</argument>
+                                <argument>venv</argument>
+                                <argument>env</argument>
                             </arguments>
                         </configuration>
-                        <phase>verify</phase>
+                        <phase>test</phase>
                         <goals>
                             <goal>exec</goal>
                         </goals>
                     </execution>
                     <execution>
-                        <id>generate python env</id>
+                        <id>Upgrade pip</id>
                         <configuration>
-                            <executable>python3</executable>
-                            <workingDirectory>${project.build.directory}</workingDirectory>
+                            <executable>env/bin/pip3</executable>
+                            <workingDirectory>${project.build.directory}</workingDirectory> 
                             <arguments>
-                                <argument>-m</argument>
-                                <argument>venv</argument>
-                                <argument>env</argument>
+                                <argument>install</argument>
+                                <argument>--upgrade</argument>
+                                <argument>pip</argument>
                             </arguments>
                         </configuration>
                         <phase>test</phase>
@@ -201,6 +202,36 @@ Portions Copyright (c) 2017-2018, Chris Fraire <[email protected]>.
                             <goal>exec</goal>
                         </goals>
                     </execution>
+                    <execution>
+                        <id>Install Python lint</id>
+                        <configuration>
+                            <executable>${project.build.directory}/env/bin/pip3</executable>
+                            <arguments>
+                                <argument>install</argument>
+                                <argument>pylint</argument>
+                            </arguments>
+                        </configuration>
+                        <phase>verify</phase>
+                        <goals>
+                            <goal>exec</goal>
+                        </goals>
+                    </execution>
+                    <execution>
+                        <id>Python lint</id>
+                        <configuration>
+                            <executable>env/bin/pylint</executable>
+                            <workingDirectory>${project.build.directory}</workingDirectory>
+                            <arguments>
+                                <argument>-E</argument>
+                                <argument>${project.build.sourceDirectory}/opengrok_tools</argument>
+                                <argument>${project.build.directory}/setup.py</argument>
+                            </arguments>
+                        </configuration>
+                        <phase>verify</phase>
+                        <goals>
+                            <goal>exec</goal>
+                        </goals>
+                    </execution>
                     <execution>
                         <id>python-test</id>
                         <configuration>

opengrok-tools/src/main/python/requirements.txt

@@ -6,7 +6,7 @@ jsonschema==2.6.0
 JsonSir==0.0.2
 Python-EasyConfig==0.1.7
 PyYAML==3.13
-requests>=2.2.1
+requests==2.19.1
 Resource==0.2.1
-six>=1.5.0
-urllib3>=1.7
+six==1.11.0
+urllib3==1.23