rename ldap -> ldapProvider

Author: Vladimir Kotal

plugins/src/opengrok/auth/plugin/AbstractLdapPlugin.java

@@ -18,7 +18,7 @@
  */
 
 /*
- * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved.
  */
 package opengrok.auth.plugin;
 
@@ -80,7 +80,7 @@ abstract public class AbstractLdapPlugin implements IAuthorizationPlugin {
     /**
      * LDAP lookup facade.
      */
-    private AbstractLdapProvider ldap;
+    private AbstractLdapProvider ldapProvider;
 
     public AbstractLdapPlugin() {
         SESSION_USERNAME += "-" + nextId;
@@ -124,7 +124,7 @@ public void load(Map<String, Object> parameters) {
 
         if ((fake = (Boolean) parameters.get(FAKE_PARAM)) != null
                 && fake) {
-            ldap = new FakeLdapFacade();
+            ldapProvider = new FakeLdapFacade();
             return;
         }
 
@@ -134,7 +134,7 @@ public void load(Map<String, Object> parameters) {
 
         try {
             cfg = getConfiguration(configurationPath);
-            ldap = new LdapFacade(cfg);
+            ldapProvider = new LdapFacade(cfg);
         } catch (IOException ex) {
             throw new IllegalArgumentException("Unable to read the configuration", ex);
         }
@@ -162,9 +162,9 @@ protected Configuration getConfiguration(String configurationPath) throws IOExce
      */
     @Override
     public void unload() {
-        if (ldap != null) {
-            ldap.close();
-            ldap = null;
+        if (ldapProvider != null) {
+            ldapProvider.close();
+            ldapProvider = null;
         }
         cfg = null;
     }
@@ -184,7 +184,7 @@ public Configuration getConfiguration() {
      * @return the LDAP provider
      */
     public AbstractLdapProvider getLdapProvider() {
-        return ldap;
+        return ldapProvider;
     }
 
     /**
@@ -254,7 +254,7 @@ && isSameUser((String) req.getSession().getAttribute(SESSION_USERNAME), user.get
 
         updateSession(req, user.getUsername(), false);
 
-        if (ldap == null) {
+        if (ldapProvider == null) {
             return;
         }