Update plugins/src/main/java/opengrok/auth/plugin/LdapAttrPlugin.java

accept review comment

Co-authored-by: Adam Hornáček <[email protected]>

Author: Vladimir Kotal

plugins/src/main/java/opengrok/auth/plugin/LdapAttrPlugin.java

@@ -128,9 +128,8 @@ String getSessionAllowedAttrName() {
     public void fillSession(HttpServletRequest req, User user) {
         updateSession(req, false);
 
-        LdapUser ldapUser;
-        if ((ldapUser = (LdapUser) req.getSession().
-                getAttribute(LdapUserPlugin.getSessionAttrName(ldapUserInstance))) == null) {
+        LdapUser ldapUser = (LdapUser) req.getSession().                getAttribute(LdapUserPlugin.getSessionAttrName(ldapUserInstance));
+        if (ldapUser == null) {
             LOGGER.log(Level.WARNING, "cannot get {0} attribute from {1}",
                     new Object[]{LdapUserPlugin.SESSION_ATTR, user});
             return;