use Consumer instead of the visitor interface

Author: Vladimir Kotal

opengrok-indexer/src/main/java/org/opengrok/indexer/history/BoundaryChangesets.java

@@ -34,9 +34,9 @@
 /**
  * Helper class to split sequence of VCS changesets into number of intervals.
  * This is then used in {@link Repository#createCache(HistoryCache, String)}
- * to store history in chunks, for VCS repositories that supports this.
+ * to store history in chunks, for VCS repositories that support this.
  */
-public class BoundaryChangesets implements ChangesetVisitorInterface {
+public class BoundaryChangesets {
     private int cnt = 0;
     private final List<String> result = new ArrayList<>();
 
@@ -70,7 +70,7 @@ public synchronized List<String> getBoundaryChangesetIDs(String sinceRevision) t
         LOGGER.log(Level.FINE, "getting boundary changesets for ''{0}''", repository.getDirectoryName());
         Statistics stat = new Statistics();
 
-        repository.accept(sinceRevision, this);
+        repository.accept(sinceRevision, this::visit);
 
         // The changesets need to go from oldest to newest.
         Collections.reverse(result);
@@ -85,8 +85,7 @@ public synchronized List<String> getBoundaryChangesetIDs(String sinceRevision) t
         return result;
     }
 
-    @Override
-    public void visit(String id) {
+    private void visit(String id) {
         if (cnt != 0 && cnt % maxCount == 0) {
             result.add(id);
         }

opengrok-indexer/src/main/java/org/opengrok/indexer/history/GitRepository.java

@@ -49,6 +49,7 @@
 import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
+import java.util.function.Consumer;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.regex.Matcher;
@@ -534,7 +535,7 @@ public int getPerPartesCount() {
         return MAX_CHANGESETS;
     }
 
-    public void accept(String sinceRevision, ChangesetVisitorInterface visitor) throws HistoryException {
+    public void accept(String sinceRevision, Consumer<String> visitor) throws HistoryException {
         try (org.eclipse.jgit.lib.Repository repository = getJGitRepository(getDirectoryName());
              RevWalk walk = new RevWalk(repository)) {
 
@@ -545,7 +546,7 @@ public void accept(String sinceRevision, ChangesetVisitorInterface visitor) thro
 
             for (RevCommit commit : walk) {
                 // Do not abbreviate the Id as this could cause AmbiguousObjectException in getHistory().
-                visitor.visit(commit.getId().name());
+                visitor.accept(commit.getId().name());
             }
         } catch (IOException e) {
             throw new HistoryException(e);

opengrok-indexer/src/main/java/org/opengrok/indexer/history/RepositoryWithPerPartesHistory.java

@@ -23,6 +23,7 @@
 package org.opengrok.indexer.history;
 
 import java.io.File;
+import java.util.function.Consumer;
 
 /**
  * Repositories extending this class will benefit from per partes history
@@ -56,5 +57,5 @@ public int getPerPartesCount() {
      * @param visitor object implementing the {@link ChangesetVisitorInterface} interface
      * @throws HistoryException on error during history retrieval
      */
-    public abstract void accept(String sinceRevision, ChangesetVisitorInterface visitor) throws HistoryException;
+    public abstract void accept(String sinceRevision, Consumer<String> visitor) throws HistoryException;
 }