Skip to content

Commit 46c2c12

Browse files
committed
Fixed failing Ctags test
New signature parsing algorithm picks up more symbols than previous one.
1 parent dbb92cc commit 46c2c12

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

test/org/opensolaris/opengrok/analysis/CtagsParserTest.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class CtagsParserTest {
3333

3434
@Test
3535
public void ctags_vs_universal_ctags() throws Exception {
36-
String universal_ctags_c = "TEST\tsample.c\t/^#define TEST(/;\"\tmacro\tline:6\tsignature:(x)\n"
36+
String universal_ctags_c = "TEST\tsample.c\t/^#define TEST($/;\"\tmacro\tline:6\tsignature:(x)\n"
3737
+ "foo\tsample.c\t/^int foo(int a, int b) {$/;\"\tfunction\tline:8\ttyperef:typename:int\tsignature:(int a, int b)\n"
3838
+ "c\tsample.c\t/^ int c;$/;\"\tlocal\tline:13\tfunction:foo\ttyperef:typename:int\n"
3939
+ "msg\tsample.c\t/^ const char *msg = \"this is } sample { string\";$/;\"\tlocal\tline:14\tfunction:foo\ttyperef:typename:const char *\n"
@@ -42,9 +42,8 @@ public void ctags_vs_universal_ctags() throws Exception {
4242
+ "f\tsample.c\t/^ int f;$/;\"\tlocal\tline:28\tfunction:bar\ttyperef:typename:int\n"
4343
+ "main\tsample.c\t/^int main(int argc, char *argv[]) {$/;\"\tfunction\tline:41\ttyperef:typename:int\tsignature:(int argc, char *argv[])\n"
4444
+ "res\tsample.c\t/^ int res;$/;\"\tlocal\tline:42\tfunction:main\ttyperef:typename:int";
45-
String ctags_c = "TEST\tsample.c\t6;\"\tmacro\tline:6\n"
46-
+ // this has wrong address so it shouldn't be detected
47-
"foo\tsample.c\t/^int foo(int a, int b) {$/;\"\tfunction\tline:8\tsignature:(int a, int b)\n"
45+
String ctags_c = "TEST\tsample.c\t6;\"\tmacro\tline:6\n" // this has wrong address so it shouldn't be detected
46+
+ "foo\tsample.c\t/^int foo(int a, int b) {$/;\"\tfunction\tline:8\tsignature:(int a, int b)\n"
4847
+ "c\tsample.c\t/^ int c;$/;\"\tlocal\tline:13\n"
4948
+ "msg\tsample.c\t/^ const char *msg = \"this is } sample { string\";$/;\"\tlocal\tline:14\n"
5049
+ "bar\tsample.c\t/^int bar(int x \\/* } *\\/)$/;\"\tfunction\tline:24\tsignature:(int x )\n"
@@ -57,10 +56,10 @@ public void ctags_vs_universal_ctags() throws Exception {
5756

5857
Definitions cDefs = lctags.testCtagsParser(ctags_c);
5958

60-
assertEquals(12, cDefs.getTags().size());
61-
assertEquals(13, ucDefs.getTags().size());
59+
assertEquals(13, cDefs.getTags().size());
60+
assertEquals(15, ucDefs.getTags().size());
6261

63-
String uc_cxx = "TEST\tsample.cxx\t/^#define TEST(/;\"\tmacro\tline:7\tsignature:(x)\n"
62+
String uc_cxx = "TEST\tsample.cxx\t/^#define TEST($/;\"\tmacro\tline:7\tsignature:(x)\n"
6463
+ "SomeClass\tsample.cxx\t/^class SomeClass {$/;\"\tclass\tline:9\n"
6564
+ "SomeClass\tsample.cxx\t/^ SomeClass() \\/* I'm constructor *\\/$/;\"\tfunction\tline:11\tclass:SomeClass\tsignature:()\n"
6665
+ "~SomeClass\tsample.cxx\t/^ ~SomeClass() \\/\\/ destructor$/;\"\tfunction\tline:17\tclass:SomeClass\tsignature:()\n"
@@ -114,8 +113,8 @@ public void ctags_vs_universal_ctags() throws Exception {
114113

115114
cDefs = lctags.testCtagsParser(c_cxx);
116115

117-
assertEquals(35, cDefs.getTags().size());
118-
assertEquals(28, ucDefs.getTags().size());
116+
assertEquals(37, cDefs.getTags().size());
117+
assertEquals(31, ucDefs.getTags().size());
119118

120119
String uc_java = "org.opensolaris.opengrok.analysis.java\thome/jobs/OpenGrokAnt/workspace/testdata/sources/java/Sample.java\t/^package org.opensolaris.opengrok.analysis.java;$/;\"\tpackage\tline:23\n"
121120
+ "Sample\thome/jobs/OpenGrokAnt/workspace/testdata/sources/java/Sample.java\t/^public class Sample {$/;\"\tclass\tline:25\n"

0 commit comments

Comments
 (0)