refactor

Author: vladak

src/org/opensolaris/opengrok/history/HistoryGuru.java

@@ -42,6 +42,7 @@
 import org.opensolaris.opengrok.configuration.Configuration.RemoteSCM;
 import org.opensolaris.opengrok.configuration.RuntimeEnvironment;
 import org.opensolaris.opengrok.index.IgnoredNames;
+import org.opensolaris.opengrok.util.Statistics;
 import org.opensolaris.opengrok.util.StringUtils;
 
 /**
@@ -484,7 +485,7 @@ private void createCache(Repository repository, String sinceRevision) {
 
         if (repository.isWorking()) {
             boolean verbose = RuntimeEnvironment.getInstance().isVerbose();
-            long start = System.currentTimeMillis();
+            Statistics elapsed = new Statistics();
 
             if (verbose) {
                 log.log(Level.INFO, "Creating historycache for {0} ({1})",
@@ -500,10 +501,7 @@ private void createCache(Repository repository, String sinceRevision) {
             }
 
             if (verbose) {
-                long stop = System.currentTimeMillis();
-                String time_str = StringUtils.getReadableTime(stop - start);
-                log.log(Level.INFO, "Done historycache for {0} (took {1})",
-                    new Object[]{path, time_str});
+                elapsed.report(log, "Done historycache for " + path);
             }
         } else {
             log.log(Level.WARNING, "Skipping creation of historycache of "
@@ -512,7 +510,7 @@ private void createCache(Repository repository, String sinceRevision) {
     }
 
     private void createCacheReal(Collection<Repository> repositories) {
-        long start = System.currentTimeMillis();
+        Statistics elapsed = new Statistics();
         ExecutorService executor = RuntimeEnvironment.getHistoryExecutor();
         // Since we know each repository object from the repositories
         // collection is unique, we can abuse HashMap to create a list of
@@ -596,10 +594,7 @@ public void run() {
             OpenGrokLogger.getLogger().log(Level.WARNING,
                     "Failed optimizing the history cache database", he);
         }
-        long stop = System.currentTimeMillis();
-        String time_str = StringUtils.getReadableTime(stop - start);
-        log.log(Level.INFO, "Done historycache for all repositories (took {0})",
-            time_str);
+        elapsed.report(log, "Done historycache for all repositories");
         historyCache.setHistoryIndexDone();
     }
 

src/org/opensolaris/opengrok/index/Indexer.java

@@ -549,7 +549,6 @@ public static void main(String argv[]) {
                     System.out.println("History stored in DB and renamed file handling is on - possible performance degradation");
                 }
 
-                long start = System.currentTimeMillis();
                 getInstance().prepareIndexer(env, searchRepositories, addProjects,
                         defaultProject, configFilename, refreshHistory,
                         listFiles, createDict, subFiles, repositories,
@@ -562,9 +561,6 @@ public static void main(String argv[]) {
                     getInstance().doIndexerExecution(update, noThreads, subFiles,
                             progress);
                 }
-                long stop = System.currentTimeMillis();
-                String time_str = StringUtils.getReadableTime(stop - start);
-                log.log(Level.INFO, "Total indexing time: {0}", time_str);
                 getInstance().sendToConfigHost(env, configHost);
             } catch (IndexerException ex) {
                 log.log(Level.SEVERE, "Exception running indexer", ex);
@@ -763,7 +759,7 @@ public int compare(Project p1, Project p2) {
     public void doIndexerExecution(final boolean update, int noThreads, List<String> subFiles,
             IndexChangedListener progress)
             throws IOException {
-        long start = System.currentTimeMillis();
+        Statistics elapsed = new Statistics();
         RuntimeEnvironment env = RuntimeEnvironment.getInstance().register();
         log.info("Starting indexing");
 
@@ -844,10 +840,7 @@ public void run() {
             log.log(Level.SEVERE,
                 "destroying of renamed thread pool failed", ex);
         }
-        long stop = System.currentTimeMillis();
-        String time_str = StringUtils.getReadableTime(stop - start);
-        log.log(Level.INFO, "Done indexing data of all repositories (took {0})",
-            time_str);
+        elapsed.report(log, "Done indexing data of all repositories");
     }
 
     public void sendToConfigHost(RuntimeEnvironment env, String configHost) {
@@ -859,7 +852,8 @@ public void sendToConfigHost(RuntimeEnvironment env, String configHost) {
                     InetAddress host = InetAddress.getByName(cfg[0]);
                     env.writeConfiguration(host, Integer.parseInt(cfg[1]));
                 } catch (Exception ex) {
-                    log.log(Level.SEVERE, "Failed to send configuration to " + configHost + " (is web application server running with opengrok deployed?)", ex);
+                    log.log(Level.SEVERE, "Failed to send configuration to "
+                        + configHost + " (is web application server running with opengrok deployed?)", ex);
                 }
             } else {
                 log.severe("Syntax error: ");

src/org/opensolaris/opengrok/util/Statistics.java

@@ -35,6 +35,12 @@ public Statistics() {
       startTime = System.currentTimeMillis();    
   }
 
+  public void report(Logger log, String msg) {
+      long stopTime = System.currentTimeMillis();
+      String time_str = StringUtils.getReadableTime(stopTime - startTime);
+      log.log(Level.INFO, msg + " (took {0})", time_str);
+  }
+
   public void report(Logger log) {
     long stopTime = System.currentTimeMillis() - startTime;
     log.log(Level.INFO, "Total time: {0}", getReadableTime(stopTime));