Skip to content

Commit 4dd83a6

Browse files
tulinkryVladimir Kotal
authored andcommitted
indenting only real subrepositories of the project (#2679)
fixes #2672
1 parent d9038ba commit 4dd83a6

File tree

1 file changed

+43
-14
lines changed

1 file changed

+43
-14
lines changed

opengrok-web/src/main/webapp/repos.jspf

Lines changed: 43 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,21 @@ CDDL HEADER END
2121
Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved.
2222

2323
--%>
24-
<%@page import="java.util.TreeSet"%>
24+
<%@page import="java.io.File"%>
25+
<%@page import="java.util.Collections"%>
26+
<%@page import="java.util.Comparator"%>
2527
<%@page import="java.util.Iterator"%>
28+
<%@page import="java.util.LinkedList"%>
29+
<%@page import="java.util.List"%>
2630
<%@page import="java.util.Set"%>
31+
<%@page import="java.util.TreeSet"%>
32+
<%@page import="org.opengrok.indexer.configuration.Group"%>
33+
<%@page import="org.opengrok.indexer.configuration.Project"%>
34+
<%@page import="org.opengrok.indexer.history.RepositoryInfo"%>
35+
<%@page import="org.opengrok.indexer.web.PageConfig"%>
2736
<%@page import="org.opengrok.indexer.web.Prefix"%>
2837
<%@page import="org.opengrok.indexer.web.ProjectHelper"%>
29-
<%@page import="java.util.LinkedList"%>
30-
<%@page import="java.util.Collections"%>
31-
<%@page import="java.util.Comparator"%>
32-
<%@page import="java.io.File"%>
33-
<%@page import="org.opengrok.indexer.history.RepositoryInfo"%>
3438
<%@page import="org.opengrok.indexer.web.Util"%>
35-
<%@page import="org.opengrok.indexer.configuration.Project"%>
36-
<%@page import="org.opengrok.indexer.configuration.Group"%>
37-
<%@page import="java.util.List"%>
38-
<%@page import="org.opengrok.indexer.web.PageConfig"%>
3939
<%@ page import="static org.opengrok.indexer.web.messages.MessagesUtils.printMessages" %>
4040
<%@ page import="static org.opengrok.indexer.web.messages.MessagesUtils.messagesToJson" %>
4141
<%
@@ -156,13 +156,28 @@ Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved.
156156
if (cnt > 0 && ri.getParent() == null)
157157
// discard repositories without a parent url
158158
continue;
159-
if (cnt != 0) {
159+
160+
boolean subrepository = !ri.getDirectoryNameRelative().equals(project.getPath());
161+
if (subrepository && cnt == 0) {
162+
%>
163+
<tr>
164+
<td class="name repository" colspan="3">
165+
<a href="<%= request.getContextPath() + Prefix.XREF_P + "/" + projDesc %>"
166+
title="Xref for project <%= Util.htmlize(projDesc) %>">
167+
<%= Util.htmlize(projDesc) %>
168+
</a>
169+
</td>
170+
</tr>
171+
<%
172+
}
173+
174+
if (subrepository) {
160175
projDesc = ri.getDirectoryName()
161176
.replace(cfg.getSourceRootPath() + File.separator, "");
162177
}
163178
%>
164179
<tr>
165-
<td class="name <%= cnt > 0 ? "subrepository" : "repository" %>">
180+
<td class="name <%= subrepository ? "subrepository" : "repository" %>">
166181
<a href="<%= request.getContextPath() + Prefix.XREF_P + "/" + projDesc%>"
167182
title="Xref for project <%= Util.htmlize(projDesc) %>">
168183
<%= Util.htmlize(projDesc) %>
@@ -287,12 +302,26 @@ Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved.
287302
if (cnt > 0 && ri.getParent() == null)
288303
// discard repositories without a parent url
289304
continue;
290-
if (cnt != 0) {
305+
boolean subrepository = !ri.getDirectoryNameRelative().equals(proj.getPath());
306+
if (subrepository && cnt == 0) {
307+
%>
308+
<tr>
309+
<td class="name repository" colspan="3">
310+
<a href="<%= request.getContextPath() + Prefix.XREF_P + "/" + projDesc %>"
311+
title="Xref for project <%= Util.htmlize(projDesc) %>">
312+
<%= Util.htmlize(projDesc) %>
313+
</a>
314+
</td>
315+
</tr>
316+
<%
317+
}
318+
319+
if (subrepository) {
291320
projDesc = ri.getDirectoryName()
292321
.replace(cfg.getSourceRootPath() + File.separator, "");
293322
}
294323
%>
295-
<tr><td class="name <%= cnt > 0 ? "subrepository" : "repository" %>">
324+
<tr><td class="name <%= subrepository ? "subrepository" : "repository" %>">
296325
<a href="<%= request.getContextPath() + Prefix.XREF_P + "/" + projDesc %>"
297326
title="Xref for project <%= Util.htmlize(projDesc) %>">
298327
<%= Util.htmlize(projDesc) %>

0 commit comments

Comments
 (0)